linux-kernel - Re: [PATCH v2 2/2] Input: atkbd - Correctly map F13

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <dfde599f-c01d-48a2-a315-0b80d5954623@tuxedocomputers.com>
Date: Tue, 22 Jul 2025 13:53:28 +0200
From: Werner Sembach <wse@...edocomputers.com>
To: Hans de Goede <hansg@...nel.org>,
 Dmitry Torokhov <dmitry.torokhov@...il.com>
Cc: linux-input@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 2/2] Input: atkbd - Correctly map F13 - F24

Hi,

Am 22.07.25 um 09:04 schrieb Hans de Goede:
> Hi Werner,
>
> On 21-Jul-25 10:36 PM, Werner Sembach wrote:
>> Hi,
>>
>> Am 15.05.25 um 14:26 schrieb Werner Sembach:
>>> Hi,
>>>
>>> Am 17.03.25 um 23:23 schrieb Hans de Goede:
>>>> Hi Werner,
>>>>
>>>> On 17-Mar-25 6:00 PM, Werner Sembach wrote:
>>>>> [...]
>>>> I think this one will apply cleanly without applying patch 1/2
>>>> first, so no reason for a resend / v3 AFAICT.
>>>>
>>>> Let's wait and see what feedback Dmitry have once he can make
>>>> some time to take a look at this.
>>> Hope a gentle bump is ok by now?
>>>
>>> Best regards,
>>>
>>> Werner
>> Small bump again, just so that this does not get forgotten.
> It might be best to just resend this (rebased on the latest
> upstream) as a standalone v3 patch (with my reviewed-by
> added).

kk

Best Regards,

Werner

>
> Regards,
>
> Hans
>
>
>
>
>
>
>>>>>>> ---
>>>>>>>     drivers/input/keyboard/atkbd.c | 12 ++++++------
>>>>>>>     1 file changed, 6 insertions(+), 6 deletions(-)
>>>>>>>
>>>>>>> diff --git a/drivers/input/keyboard/atkbd.c b/drivers/input/keyboard/atkbd.c
>>>>>>> index 3598a21d9d014..4bd6e6ef0715e 100644
>>>>>>> --- a/drivers/input/keyboard/atkbd.c
>>>>>>> +++ b/drivers/input/keyboard/atkbd.c
>>>>>>> @@ -84,12 +84,12 @@ static const unsigned short atkbd_set2_keycode[ATKBD_KEYMAP_SIZE] = {
>>>>>>>     #include "hpps2atkbd.h"    /* include the keyboard scancodes */
>>>>>>>       #else
>>>>>>> -      0, 67, 65, 63, 61, 59, 60, 88,  0, 68, 66, 64, 62, 15, 41,117,
>>>>>>> -      0, 56, 42, 93, 29, 16,  2,  0,  0,  0, 44, 31, 30, 17,  3,  0,
>>>>>>> -      0, 46, 45, 32, 18,  5,  4, 95,  0, 57, 47, 33, 20, 19,  6,183,
>>>>>>> -      0, 49, 48, 35, 34, 21,  7,184,  0,  0, 50, 36, 22, 8,  9,185,
>>>>>>> -      0, 51, 37, 23, 24, 11, 10,  0,  0, 52, 53, 38, 39, 25, 12,  0,
>>>>>>> -      0, 89, 40,  0, 26, 13,  0,193, 58, 54, 28, 27,  0, 43,  0, 85,
>>>>>>> +      0, 67, 65, 63, 61, 59, 60, 88,183, 68, 66, 64, 62, 15, 41,117,
>>>>>>> +    184, 56, 42, 93, 29, 16,  2,  0,185,  0, 44, 31, 30, 17,  3,  0,
>>>>>>> +    186, 46, 45, 32, 18,  5,  4, 95,187, 57, 47, 33, 20, 19,  6,183,
>>>>>>> +    188, 49, 48, 35, 34, 21,  7,184,189,  0, 50, 36, 22, 8,  9,185,
>>>>>>> +    190, 51, 37, 23, 24, 11, 10,  0,191, 52, 53, 38, 39, 25, 12,  0,
>>>>>>> +    192, 89, 40,  0, 26, 13,  0,193, 58, 54, 28, 27,  0, 43,  0,194,
>>>>>>>           0, 86, 91, 90, 92,  0, 14, 94,  0, 79,124, 75, 71,121,  0,  0,
>>>>>>>          82, 83, 80, 76, 77, 72,  1, 69, 87, 78, 81, 74, 55, 73, 70, 99,