linux-kernel - Re: [PATCH v4 1/2] dt-bindings: regulator: Add Richtek RTR5133 Support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <50908790-f4a3-41ee-a270-83be3e74c1a1@sirena.org.uk>
Date: Tue, 22 Jul 2025 12:54:07 +0100
From: Mark Brown <broonie@...nel.org>
To: Krzysztof Kozlowski <krzk@...nel.org>
Cc: jeff_chang@...htek.com, lgirdwood@...il.com, robh@...nel.org,
	krzk+dt@...nel.org, conor+dt@...nel.org,
	linux-kernel@...r.kernel.org, devicetree@...r.kernel.org
Subject: Re: [PATCH v4 1/2] dt-bindings: regulator: Add Richtek RTR5133
 Support

On Tue, Jul 22, 2025 at 11:04:51AM +0200, Krzysztof Kozlowski wrote:
> On 22/07/2025 10:34, jeff_chang@...htek.com wrote:

> > +      base:
> > +        type: object
> > +        $ref: regulator.yaml#
> > +        unevaluatedProperties: false
> > +        description:
> > +          Properties for base regulator which control force-off base circuit.
> > +          Base circuit is the power source for LDO1~LDO6. Disabling it will
> > +          reduce IQ for Chip.

> I don't understand what this regulator is for. Your example is also
> incomplete - missing min/max constraints like voltage.

> Explain, what is this output pin? I already asked for explanations. I
> have diagram in front of me, so explain precisely instead of sending THE
> SAME again - which pin is it?

It's the top level supply for the chip, it's likely not externally
visible and sounds like it's just an on/off switch rather than
regulating voltages.  This seems fairly clear with domain knowledge.

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)