linux-kernel - RE: [PATCH v2 net-next 12/14] net: enetc: add PTP synchronization support for ENETC v4

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID:
 <PAXPR04MB851029B1395CFB3E89EEAE2D885CA@PAXPR04MB8510.eurprd04.prod.outlook.com>
Date: Tue, 22 Jul 2025 13:41:37 +0000
From: Wei Fang <wei.fang@....com>
To: Vladimir Oltean <vladimir.oltean@....com>
CC: Frank Li <frank.li@....com>, "robh@...nel.org" <robh@...nel.org>,
	"krzk+dt@...nel.org" <krzk+dt@...nel.org>, "conor+dt@...nel.org"
	<conor+dt@...nel.org>, "richardcochran@...il.com" <richardcochran@...il.com>,
	Claudiu Manoil <claudiu.manoil@....com>, Clark Wang <xiaoning.wang@....com>,
	"andrew+netdev@...n.ch" <andrew+netdev@...n.ch>, "davem@...emloft.net"
	<davem@...emloft.net>, "edumazet@...gle.com" <edumazet@...gle.com>,
	"kuba@...nel.org" <kuba@...nel.org>, "pabeni@...hat.com" <pabeni@...hat.com>,
	"vadim.fedorenko@...ux.dev" <vadim.fedorenko@...ux.dev>,
	"shawnguo@...nel.org" <shawnguo@...nel.org>, "s.hauer@...gutronix.de"
	<s.hauer@...gutronix.de>, "festevam@...il.com" <festevam@...il.com>, "F.S.
 Peng" <fushi.peng@....com>, "devicetree@...r.kernel.org"
	<devicetree@...r.kernel.org>, "netdev@...r.kernel.org"
	<netdev@...r.kernel.org>, "linux-kernel@...r.kernel.org"
	<linux-kernel@...r.kernel.org>, "imx@...ts.linux.dev" <imx@...ts.linux.dev>,
	"kernel@...gutronix.de" <kernel@...gutronix.de>
Subject: RE: [PATCH v2 net-next 12/14] net: enetc: add PTP synchronization
 support for ENETC v4

> On Fri, Jul 18, 2025 at 05:08:09AM +0300, Wei Fang wrote:
> > > > > > +static inline bool enetc_ptp_clock_is_enabled(struct enetc_si *si) {
> > > > > > +	if (is_enetc_rev1(si))
> > > > > > +		return IS_ENABLED(CONFIG_FSL_ENETC_PTP_CLOCK);
> > > > > > +
> > > > > > +	return IS_ENABLED(CONFIG_PTP_1588_CLOCK_NETC);
> > > > > > +}
> > > > > > +
> > > > >
> > > > > why v1 check CONFIG_FSL_ENETC_PTP_CLOCK and other check
> > > > > CONFIG_PTP_1588_CLOCK_NETC
> > > >
> > > > Because they use different PTP drivers, so the configs are different.
> > >
> > > But name CONFIG_FSL_ENETC_PTP_CLOCK and
> > > CONFIG_PTP_1588_CLOCK_NETC is quite
> > > similar, suppose CONFIG_PTP_1588_CLOCK_NETC should be
> > > CONFIG_PTP_1588_CLOCK_NETC_V4
> > >
> > Okay, it looks good
> 
> The help text is also very confusing, nowhere is it specified that the
> new driver is for NETCv4, the reader can just as well interpret it that
> the LS1028A ENETC can use this PTP timer driver.
> 
> +         This driver adds support for using the NXP NETC Timer as a PTP
> +         clock. This clock is used by ENETC MAC or NETC Switch for PTP
> +         synchronization. It also supports periodic output signal (e.g.
> +         PPS) and external trigger timestamping.

Thanks for pointing out this, let me improve the description in the next
version.