linux-kernel - Re: [PATCH] mm/damon/ops-common: ignore migration request to invalid nodes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20250721195658.935f5e2436045cc311575c9c@linux-foundation.org>
Date: Mon, 21 Jul 2025 19:56:58 -0700
From: Andrew Morton <akpm@...ux-foundation.org>
To: SeongJae Park <sj@...nel.org>
Cc: Honggyu Kim <honggyu.kim@...com>, Hyeongtak Ji <hyeongtak.ji@...com>,
 damon@...ts.linux.dev, linux-kernel@...r.kernel.org, linux-mm@...ck.org,
 stable@...r.kernel.org
Subject: Re: [PATCH] mm/damon/ops-common: ignore migration request to
 invalid nodes

On Sun, 20 Jul 2025 11:58:22 -0700 SeongJae Park <sj@...nel.org> wrote:

> damon_migrate_pages() try migration even if the target node is invalid.
> If users mistakenly make such invalid requests via
> DAMOS_MIGRATE_{HOT,COLD} action, below kernel BUG can happen.
> 
>     [ 7831.883495] BUG: unable to handle page fault for address: 0000000000001f48
>     [ 7831.884160] #PF: supervisor read access in kernel mode
>     [ 7831.884681] #PF: error_code(0x0000) - not-present page
>     [ 7831.885203] PGD 0 P4D 0
>     [ 7831.885468] Oops: Oops: 0000 [#1] SMP PTI
>     [ 7831.885852] CPU: 31 UID: 0 PID: 94202 Comm: kdamond.0 Not tainted 6.16.0-rc5-mm-new-damon+ #93 PREEMPT(voluntary)
>     [ 7831.886913] Hardware name: QEMU Standard PC (i440FX + PIIX, 1996), BIOS 1.16.3-4.el9 04/01/2014
>     [ 7831.887777] RIP: 0010:__alloc_frozen_pages_noprof (include/linux/mmzone.h:1724 include/linux/mmzone.h:1750 mm/page_alloc.c:4936 mm/page_alloc.c:5137)
>     [...]
>     [ 7831.895953] Call Trace:
>     [ 7831.896195]  <TASK>
>     [ 7831.896397] __folio_alloc_noprof (mm/page_alloc.c:5183 mm/page_alloc.c:5192)
>     [ 7831.896787] migrate_pages_batch (mm/migrate.c:1189 mm/migrate.c:1851)
>     [ 7831.897228] ? __pfx_alloc_migration_target (mm/migrate.c:2137)
>     [ 7831.897735] migrate_pages (mm/migrate.c:2078)
>     [ 7831.898141] ? __pfx_alloc_migration_target (mm/migrate.c:2137)
>     [ 7831.898664] damon_migrate_folio_list (mm/damon/ops-common.c:321 mm/damon/ops-common.c:354)
>     [ 7831.899140] damon_migrate_pages (mm/damon/ops-common.c:405)
>     [...]
> 
> Add a target node validity check in damon_migrate_pages().  The validity
> check is stolen from that of do_pages_move(), which is being used for
> move_pages() system call.
> 
> Fixes: b51820ebea65 ("mm/damon/paddr: introduce DAMOS_MIGRATE_COLD action for demotion") # 6.11.x
> Cc: stable@...r.kernel.org
>
> ...
>
> --- a/mm/damon/ops-common.c
> +++ b/mm/damon/ops-common.c
> @@ -383,6 +383,10 @@ unsigned long damon_migrate_pages(struct list_head *folio_list, int target_nid)
>  	if (list_empty(folio_list))
>  		return nr_migrated;
>  
> +	if (target_nid < 0 || target_nid >= MAX_NUMNODES ||
> +			!node_state(target_nid, N_MEMORY))
> +		return nr_migrated;
> +
>  	noreclaim_flag = memalloc_noreclaim_save();
>  
>  	nid = folio_nid(lru_to_folio(folio_list));
> 

OK.  damon_migrate_pages() exists only in mm.git thanks to 13dde31db71f
("mm/damon: move migration helpers from paddr to ops-common").  I
assume that you'll send the -stable people a patch which adds this check into
damon_pa_migrate_pages() when called upon to do so.