[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-Id: <8742EFD5-1949-4900-ACC6-00B69C23233C@collabora.com>
Date: Wed, 23 Jul 2025 11:56:42 -0300
From: Daniel Almeida <daniel.almeida@...labora.com>
To: Danilo Krummrich <dakr@...nel.org>
Cc: Boqun Feng <boqun.feng@...il.com>,
Miguel Ojeda <ojeda@...nel.org>,
Alex Gaynor <alex.gaynor@...il.com>,
Gary Guo <gary@...yguo.net>,
Björn Roy Baron <bjorn3_gh@...tonmail.com>,
Andreas Hindborg <a.hindborg@...nel.org>,
Alice Ryhl <aliceryhl@...gle.com>,
Trevor Gross <tmgross@...ch.edu>,
Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
"Rafael J. Wysocki" <rafael@...nel.org>,
Thomas Gleixner <tglx@...utronix.de>,
Bjorn Helgaas <bhelgaas@...gle.com>,
Krzysztof Wilczy´nski <kwilczynski@...nel.org>,
Benno Lossin <lossin@...nel.org>,
linux-kernel@...r.kernel.org,
rust-for-linux@...r.kernel.org,
linux-pci@...r.kernel.org
Subject: Re: [PATCH v7 3/6] rust: irq: add support for non-threaded IRQs and
handlers
> On 23 Jul 2025, at 11:35, Danilo Krummrich <dakr@...nel.org> wrote:
>
> On 7/23/25 4:26 PM, Boqun Feng wrote:
>> On Wed, Jul 23, 2025 at 10:55:20AM -0300, Daniel Almeida wrote:
>> But sure, this and the handler pinned initializer thing is not a blocker
>> issue. However, I would like to see them resolved as soon as possible
>> once merged.
>
> I think it would be trivial to make the T an impl PinInit<T, E> and use a
> completion as example instead of an atomic. So, we should do it right away.
>
> - Danilo
I agree that this is a trivial change to make. My point here is not to postpone
the work; I am actually somewhat against switching to completions, as per the
reasoning I provided in my latest reply to Boqun. My plan is to switch directly
to whatever will substitute AtomicU32.
The switch to impl PinInit is fine.
— Daniel
Powered by blists - more mailing lists