linux-kernel - Re: [PATCH v2 2/3] ASoC: hdac_hdmi: Use dev

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1927750.tdWV9SEqCh@earth>
Date: Wed, 23 Jul 2025 11:29:07 -0400
From: Detlev Casanova <detlev.casanova@...labora.com>
To: Mark Brown <broonie@...nel.org>
Cc: linux-kernel@...r.kernel.org, Andrzej Hajda <andrzej.hajda@...el.com>,
 Neil Armstrong <neil.armstrong@...aro.org>, Robert Foss <rfoss@...nel.org>,
 Laurent Pinchart <Laurent.pinchart@...asonboard.com>,
 Jonas Karlman <jonas@...boo.se>, Jernej Skrabec <jernej.skrabec@...il.com>,
 Maarten Lankhorst <maarten.lankhorst@...ux.intel.com>,
 Maxime Ripard <mripard@...nel.org>, Thomas Zimmermann <tzimmermann@...e.de>,
 David Airlie <airlied@...il.com>, Simona Vetter <simona@...ll.ch>,
 Liam Girdwood <lgirdwood@...il.com>, Jaroslav Kysela <perex@...ex.cz>,
 Takashi Iwai <tiwai@...e.com>,
 Dmitry Baryshkov <dmitry.baryshkov@....qualcomm.com>,
 Douglas Anderson <dianders@...omium.org>, Heiko Stuebner <heiko@...ech.de>,
 Sugar Zhang <sugar.zhang@...k-chips.com>,
 Cristian Ciocaltea <cristian.ciocaltea@...labora.com>,
 Charles Keepax <ckeepax@...nsource.cirrus.com>,
 Raag Jadav <raag.jadav@...el.com>, dri-devel@...ts.freedesktop.org,
 linux-sound@...r.kernel.org, kernel@...labora.com
Subject:
 Re: [PATCH v2 2/3] ASoC: hdac_hdmi: Use dev_info on invalid ELD version

Hi Mark,
On Wednesday, 23 July 2025 06:40:13 EDT Mark Brown wrote:
> On Tue, Jul 22, 2025 at 03:54:36PM -0400, Detlev Casanova wrote:
> > When disconnected, the ELD data cannot be read by the display driver, so
> > it just sets the data to 0.
> 
> Please don't put patches for different subsystems into the same series
> if there's no dependencies, it just makes dependencies less obvious and
> creates hassle merging things.

Yes, sorry, I'll send v3 of this patch separately.

> > That makes the ELD parsing code read an ELD version of 0, which is
> > invalid. In hdac_hdmi, that is logged with dev_err(), but should be
> > logged with dev_info() instead as it is done in sound/core/pcm_drm_eld.c
> > 
> > This avoids printing multiple messages like:
> >     HDMI: Unknown ELD version 0
> > 
> > in the kernel log when userspace tries to open the sound device.
> 
> It doesn't, it just lowers the severity of the logs that are printed.
> If the goal is to lower the number of messages printed you need to use
> a ratelimited print.

I see, ratelimited would be good, but it still prints a message about 
something that is normal behaviour. Maybe this should go further to a 
dev_dbg(), or is there a specific reason to show this message ?

This could also be a special case:
 - version == 0 -> dev_dbg()
 - version !=0 && != known_versions -> dev_err()

Detlev.