linux-kernel - Re: [PATCH net 2/2] net: Warn when overriding referenced dst entry

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <aID__G3iKZqsY-yE@mini-arch>
Date: Wed, 23 Jul 2025 08:30:04 -0700
From: Stanislav Fomichev <stfomichev@...il.com>
To: Jakub Kicinski <kuba@...nel.org>
Cc: Stanislav Fomichev <sdf@...ichev.me>, netdev@...r.kernel.org,
	davem@...emloft.net, edumazet@...gle.com, pabeni@...hat.com,
	dsahern@...nel.org, andrew+netdev@...n.ch, horms@...nel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH net 2/2] net: Warn when overriding referenced dst entry

On 07/23, Jakub Kicinski wrote:
> On Wed, 23 Jul 2025 08:13:25 -0700 Stanislav Fomichev wrote:
> > > > +{
> > > > +	DEBUG_NET_WARN_ON_ONCE(skb_dst(skb) &&
> > > > +			       !(skb->_skb_refdst & SKB_DST_NOREF));  
> > > 
> > > Why not 
> > > 
> > > 	DEBUG_NET_WARN_ON_ONCE(skb->_skb_refdst & SKB_DST_PTRMASK);
> > > 
> > > ?  
> > 
> > That's more precise, agreed!
> 
> Just to be clear -- looks like I ate the
> 
>   !(skb->_skb_refdst & SKB_DST_NOREF)
> 
> part part of the condition. I think we still want that.

Ah, so you only want to get rid of those WARN_ONs in skb_dst, makes
sense.