linux-kernel - Re: [PATCH] iio: light: ltr390: Add debugfs register access support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAE3SzaSdS0pK1jA8y4WEd2ZJJfTM460j2qny1i+9pJcoc4nQ1w@mail.gmail.com>
Date: Wed, 23 Jul 2025 23:50:44 +0530
From: Akshay Jindal <akshayaj.lkd@...il.com>
To: Jonathan Cameron <jic23@...nel.org>
Cc: David Lechner <dlechner@...libre.com>, anshulusr@...il.com, nuno.sa@...log.com, 
	andy@...nel.org, shuah@...nel.org, linux-iio@...r.kernel.org, 
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] iio: light: ltr390: Add debugfs register access support

Hello Reviewers/Maintainers,

Thank you for your valuable feedback.
I truly appreciate the time and effort you took to review the patch
and share your insights. All the feedback cut the overall changes by
approx 30 lines.

I have sent a V2 patch with the following changes, which is in line
with all the feedback received.

Changes since v1:
- Replaced _[0|1|2] macros with a respective common parameterized macro.
- Retained base macros to avoid churn.
- Swapped regmap_write with regmap_read to avoid negate operator.
- Simplified debugfs function by directly returning return value of
  regmap_[read|write].
- Replaced [readable|writeable]_reg with regmap ranges by using
  [rd|wr]_table property of regmap_config.

Jonathan,
Usage of ranges in switch/case was really amusing and a new learning
for me (never used it), but I felt using rd_table/wr_table
is a much cleaner way to use register ranges while checking read/write
register availability, which is fundamentally similar to
what you suggested. Hence implemented [rd|wr]_table.

Kindly provide feedback on the updated patch as per your convenience.

Thanks,
Akshay