linux-kernel - Re: [PATCH] scsi: Fix typos

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <9c116cf4fbe4ba7515d265dd3a1a272dcfecccb1.camel@HansenPartnership.com>
Date: Wed, 23 Jul 2025 16:39:14 -0400
From: James Bottomley <James.Bottomley@...senPartnership.com>
To: Bjorn Helgaas <helgaas@...nel.org>, "Martin K . Petersen"
	 <martin.petersen@...cle.com>
Cc: linux-scsi@...r.kernel.org, linux-kernel@...r.kernel.org, Bjorn Helgaas
	 <bhelgaas@...gle.com>
Subject: Re: [PATCH] scsi: Fix typos

On Wed, 2025-07-23 at 15:26 -0500, Bjorn Helgaas wrote:
> From: Bjorn Helgaas <bhelgaas@...gle.com>
> 
> Fix typos, most reported by "codespell drivers/scsi".  Mostly touches
> comments, no code changes except
> SCU_LINK_STATUS_DWORD_SYNC_AQUIRED_*,
> which is defined but never used.

Well, this really looks like huge churn for no reason.  Plus your
codespell thing has several quirks which look wrong.  For instance:

> -#define		CFSUPREM	0x0001	/* support all
> removeable drives */
> -#define		CFSUPREMB	0x0002	/* support
> removeable boot drives */
> +#define		CFSUPREM	0x0001	/* support all
> removable drives */
> +#define		CFSUPREMB	0x0002	/* support removable
> boot drives */

removeable is an acceptable variant spelling of removable:
https://www.collinsdictionary.com/us/dictionary/english/removeable

>  			/*
>  			 * Device's PID has changed. We need to
> cleanup
>  			 * and re-login. If there is another device
> with
> -			 * the the newly discovered pid, send an scn
> notice
> -			 * so that its new pid can be discovered.
> +			 * the newly discovered PID, send an scn
> notice
> +			 * so that its new PID can be discovered.
>  			 */

so pid was inconsistently capitalised in a comment, but now scn looks
like it should be capitalised as well, so I think we can live with the
inconsistency rather than have tonnes of patches trying to capitalise
all the TLAs.

I could go on, but I'm not sure it's worth the time.

Regards,

James