lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20250723204704.GA2910768@bhelgaas>
Date: Wed, 23 Jul 2025 15:47:04 -0500
From: Bjorn Helgaas <helgaas@...nel.org>
To: James Bottomley <James.Bottomley@...senpartnership.com>
Cc: "Martin K . Petersen" <martin.petersen@...cle.com>,
	linux-scsi@...r.kernel.org, linux-kernel@...r.kernel.org,
	Bjorn Helgaas <bhelgaas@...gle.com>
Subject: Re: [PATCH] scsi: Fix typos

On Wed, Jul 23, 2025 at 04:39:14PM -0400, James Bottomley wrote:
> On Wed, 2025-07-23 at 15:26 -0500, Bjorn Helgaas wrote:
> ...

> >  			 * Device's PID has changed. We need to
> > cleanup
> >  			 * and re-login. If there is another device
> > with
> > -			 * the the newly discovered pid, send an scn
> > notice
> > -			 * so that its new pid can be discovered.
> > +			 * the newly discovered PID, send an scn
> > notice
> > +			 * so that its new PID can be discovered.
> >  			 */
> 
> so pid was inconsistently capitalised in a comment, but now scn looks
> like it should be capitalised as well, so I think we can live with the
> inconsistency rather than have tonnes of patches trying to capitalise
> all the TLAs.

The motivator for this particular hunk was the doubled "the":
s/the the/the/

It looks like this comment is the only place in the file "PID" was
capitalized, so I probably should have left it or lowercased just that
one.

> I could go on, but I'm not sure it's worth the time.

No problem, I'll ignore drivers/scsi.

Bjorn

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ