linux-kernel - Re: [PATCH v4 05/17] phy: cdns-dphy: Remove leftover code

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <b3af4b52-03e0-4e41-9666-a9af267f57b0@ideasonboard.com>
Date: Wed, 23 Jul 2025 11:49:29 +0300
From: Tomi Valkeinen <tomi.valkeinen@...asonboard.com>
To: Vinod Koul <vkoul@...nel.org>
Cc: Jyri Sarha <jyri.sarha@....fi>,
 Maarten Lankhorst <maarten.lankhorst@...ux.intel.com>,
 Maxime Ripard <mripard@...nel.org>, Thomas Zimmermann <tzimmermann@...e.de>,
 David Airlie <airlied@...il.com>, Simona Vetter <simona@...ll.ch>,
 Kishon Vijay Abraham I <kishon@...nel.org>,
 Andrzej Hajda <andrzej.hajda@...el.com>,
 Neil Armstrong <neil.armstrong@...aro.org>, Robert Foss <rfoss@...nel.org>,
 Laurent Pinchart <Laurent.pinchart@...asonboard.com>,
 Jonas Karlman <jonas@...boo.se>, Jernej Skrabec <jernej.skrabec@...il.com>,
 Jayesh Choudhary <j-choudhary@...com>, Dmitry Baryshkov <lumag@...nel.org>,
 dri-devel@...ts.freedesktop.org, linux-kernel@...r.kernel.org,
 linux-phy@...ts.infradead.org, Francesco Dolcini <francesco@...cini.it>,
 Aradhya Bhatia <aradhya.bhatia@...ux.dev>, Devarsh Thakkar
 <devarsht@...com>, Parth Pancholi <parth.pancholi@...adex.com>
Subject: Re: [PATCH v4 05/17] phy: cdns-dphy: Remove leftover code

Hi Vinod,

(I accidentally sent my mail only to you. List added here).

On 23/07/2025 10:36, Tomi Valkeinen wrote:
> Hi Vinod,
> 
> On 27/06/2025 02:32, Vinod Koul wrote:
>> On 18-06-25, 12:59, Tomi Valkeinen wrote:
>>> The code in cdns-dphy has probably been part of a DSI driver in the
>>> past. Remove DSI defines and variables which are not used or do not
>>> actually do anything. Also rename cdns_dsi_get_dphy_pll_cfg() to
>>> cdns_dphy_get_pll_cfg(), i.e. drop the "dsi", as it's not relevant here.
>>
>> Acked-by: Vinod Koul <vkoul@...nel.org>
>>
> 
> Are you fine merging the two cdns-dphy patches (this and 4/17) via drm
> tree? I think that's the easiest way to merge this.
> 
> I could also drop the 5/17 patch from the series, as it's just a
> cleanup, and it could be merged at some later point via phy tree.

Actually, I take that back. Devarsh also has some cdns-dphy patches,
which depend on my patches. It could get messy.

There's no compile-time dependency, and my DRM series doesn't depend on
the dphy changes even at runtime. I think it's best if I drop the dphy
changes from my series and send them separately.

 Tomi