linux-kernel - Re: [PATCH v2 3/4] dt-bindings: ufs: mediatek,ufs: add MT8195 compatible and update clock nodes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <438077d191833bb4f628b2c6da3b86b3ecfb40e6.camel@mediatek.com>
Date: Wed, 23 Jul 2025 09:41:36 +0000
From: Peter Wang (王信友) <peter.wang@...iatek.com>
To: "chu.stanley@...il.com" <chu.stanley@...il.com>, "robh@...nel.org"
	<robh@...nel.org>, "James.Bottomley@...senPartnership.com"
	<James.Bottomley@...senPartnership.com>, "bvanassche@....org"
	<bvanassche@....org>, AngeloGioacchino Del Regno
	<angelogioacchino.delregno@...labora.com>, "linux-scsi@...r.kernel.org"
	<linux-scsi@...r.kernel.org>, "linux-kernel@...r.kernel.org"
	<linux-kernel@...r.kernel.org>, "conor+dt@...nel.org" <conor+dt@...nel.org>,
	Macpaul Lin (林智斌) <Macpaul.Lin@...iatek.com>,
	"linux-mediatek@...ts.infradead.org" <linux-mediatek@...ts.infradead.org>,
	"devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
	"krzk+dt@...nel.org" <krzk+dt@...nel.org>, "alim.akhtar@...sung.com"
	<alim.akhtar@...sung.com>, "linux-arm-kernel@...ts.infradead.org"
	<linux-arm-kernel@...ts.infradead.org>, "matthias.bgg@...il.com"
	<matthias.bgg@...il.com>, "avri.altman@....com" <avri.altman@....com>,
	"martin.petersen@...cle.com" <martin.petersen@...cle.com>
CC: "macpaul@...il.com" <macpaul@...il.com>,
	Pablo Sun (孫毓翔) <pablo.sun@...iatek.com>,
	Project_Global_Chrome_Upstream_Group
	<Project_Global_Chrome_Upstream_Group@...iatek.com>,
	Bear Wang (萩原惟德) <bear.wang@...iatek.com>,
	Ramax Lo (羅明遠) <Ramax.Lo@...iatek.com>
Subject: Re: [PATCH v2 3/4] dt-bindings: ufs: mediatek,ufs: add MT8195
 compatible and update clock nodes

On Tue, 2025-07-22 at 11:39 +0200, AngeloGioacchino Del Regno wrote:
> 
> The unipro mp_bclk really is the ufs-sap clock; besides, the standard
> has clocks
> for both TX and RX symbols - and also MT8195 (and also MT6991,
> MT8196, and others)
> UFS controller do have both TX and RX symbol clocks.
> 
> Besides, you're also missing the crypto clocks for UFS, which brings
> the count to
> 12 total clocks for MT8195.

> Please, look at my old submission, which actually fixes the
> compatibles other than
> adding the right clocks for all UFS controllers in MediaTek
> platforms.
> 
> https://lore.kernel.org/all/20240612074309.50278-1-angelogioacchino.delregno@collabora.com/
> 

Hi Angelo,

The clock architecture may vary depending on the platform.
These clock patch look good to me.


> I want to take the occasion to remind everyone that my fixes were
> discarded because
> the MediaTek UFS driver maintainer wants to keep the low quality of
> the driver in
> favor of easier downstream porting - which is *not* in any way
> adhering to quality
> standards that the Linux community deserves.
> 
> Cheers,
> Angelo

I want to clarify that I am not opposing this in order to keep the 
low quality of the driver for the sake of easier downstream porting.
My objection is purely due to the quality of this patch:
https://lore.kernel.org/all/eb47587159484abca8e6d65dddcf0844822ce99f.camel@mediatek.com/
Originally, this could have been a simple matter handled by a single
DTS setting,
but this patch requires checking a bunch of DTS voltage settings.
This increases the complexity of the boot process, and I don't see any
benefit from it.

Even though I think the other patches look good to me, I haven't seen
any new ones uploaded.
I would like to reiterate that I welcome any upstream contributions
related to Linux UFS on MediaTek platforms.

Thanks
Peter