linux-kernel - RE: [EXTERNAL] Re: [PATCH net, 1/2] net: core: Fix missing init of llist_node in setup

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID:
 <SJ2PR21MB4013CDE051C7AEFC67B0FB9BCA5FA@SJ2PR21MB4013.namprd21.prod.outlook.com>
Date: Wed, 23 Jul 2025 00:17:17 +0000
From: Haiyang Zhang <haiyangz@...rosoft.com>
To: Kuniyuki Iwashima <kuniyu@...gle.com>, Haiyang Zhang
	<haiyangz@...ux.microsoft.com>
CC: "linux-hyperv@...r.kernel.org" <linux-hyperv@...r.kernel.org>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>, KY Srinivasan
	<kys@...rosoft.com>, "wei.liu@...nel.org" <wei.liu@...nel.org>, Dexuan Cui
	<decui@...rosoft.com>, "andrew+netdev@...n.ch" <andrew+netdev@...n.ch>,
	"sd@...asysnail.net" <sd@...asysnail.net>, "viro@...iv.linux.org.uk"
	<viro@...iv.linux.org.uk>, "chuck.lever@...cle.com" <chuck.lever@...cle.com>,
	"neil@...wn.name" <neil@...wn.name>, "edumazet@...gle.com"
	<edumazet@...gle.com>, "kuba@...nel.org" <kuba@...nel.org>,
	"pabeni@...hat.com" <pabeni@...hat.com>, "horms@...nel.org"
	<horms@...nel.org>, "davem@...emloft.net" <davem@...emloft.net>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"stable@...r.kernel.org" <stable@...r.kernel.org>
Subject: RE: [EXTERNAL] Re: [PATCH net, 1/2] net: core: Fix missing init of
 llist_node in setup_net()



> -----Original Message-----
> From: Kuniyuki Iwashima <kuniyu@...gle.com>
> Sent: Tuesday, July 22, 2025 8:02 PM
> To: Haiyang Zhang <haiyangz@...ux.microsoft.com>
> Cc: linux-hyperv@...r.kernel.org; netdev@...r.kernel.org; Haiyang Zhang
> <haiyangz@...rosoft.com>; KY Srinivasan <kys@...rosoft.com>;
> wei.liu@...nel.org; Dexuan Cui <decui@...rosoft.com>;
> andrew+netdev@...n.ch; sd@...asysnail.net; viro@...iv.linux.org.uk;
> chuck.lever@...cle.com; neil@...wn.name; edumazet@...gle.com;
> kuba@...nel.org; pabeni@...hat.com; horms@...nel.org; davem@...emloft.net;
> linux-kernel@...r.kernel.org; stable@...r.kernel.org
> Subject: [EXTERNAL] Re: [PATCH net, 1/2] net: core: Fix missing init of
> llist_node in setup_net()
> 
> [You don't often get email from kuniyu@...gle.com. Learn why this is
> important at https://aka.ms/LearnAboutSenderIdentification ]
> 
> On Tue, Jul 22, 2025 at 4:51 PM Haiyang Zhang
> <haiyangz@...ux.microsoft.com> wrote:
> >
> > From: Haiyang Zhang <haiyangz@...rosoft.com>
> >
> > Add init_llist_node for lock-less list nodes in struct net in
> > setup_net(), so we can test if a node is on a list or not.
> >
> > Cc: stable@...r.kernel.org
> > Fixes: d6b3358a2813 ("llist: add interface to check if a node is on a
> list.")
> 
> No Fixes tag is needed because we didn't have a need to
> test if net is queued for destruction.

I know the original patch wasn't buggy.
This tag is just for the stable backport version hint.

In another thread, Eric Dumazet recommended Fixes tag for patches for "stable":
https://patchwork.kernel.org/project/netdevbpf/patch/1752870014-28909-1-git-send-email-haiyangz@linux.microsoft.com/

Thanks,
- Haiyang