linux-kernel - Re: [PATCH net, 1/2] net: core: Fix missing init of llist_node in setup

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAAVpQUBuyfnv4BBxnOvheEb7JVnokTEiea5Yp4UZdX=5CuWVHg@mail.gmail.com>
Date: Tue, 22 Jul 2025 17:01:41 -0700
From: Kuniyuki Iwashima <kuniyu@...gle.com>
To: Haiyang Zhang <haiyangz@...ux.microsoft.com>
Cc: linux-hyperv@...r.kernel.org, netdev@...r.kernel.org, 
	haiyangz@...rosoft.com, kys@...rosoft.com, wei.liu@...nel.org, 
	decui@...rosoft.com, andrew+netdev@...n.ch, sd@...asysnail.net, 
	viro@...iv.linux.org.uk, chuck.lever@...cle.com, neil@...wn.name, 
	edumazet@...gle.com, kuba@...nel.org, pabeni@...hat.com, horms@...nel.org, 
	davem@...emloft.net, linux-kernel@...r.kernel.org, stable@...r.kernel.org
Subject: Re: [PATCH net, 1/2] net: core: Fix missing init of llist_node in setup_net()

On Tue, Jul 22, 2025 at 4:51 PM Haiyang Zhang
<haiyangz@...ux.microsoft.com> wrote:
>
> From: Haiyang Zhang <haiyangz@...rosoft.com>
>
> Add init_llist_node for lock-less list nodes in struct net in
> setup_net(), so we can test if a node is on a list or not.
>
> Cc: stable@...r.kernel.org
> Fixes: d6b3358a2813 ("llist: add interface to check if a node is on a list.")

No Fixes tag is needed because we didn't have a need to
test if net is queued for destruction.


> Signed-off-by: Haiyang Zhang <haiyangz@...rosoft.com>
> ---
>  net/core/net_namespace.c | 3 +++
>  1 file changed, 3 insertions(+)
>
> diff --git a/net/core/net_namespace.c b/net/core/net_namespace.c
> index ae54f26709ca..2a821849558f 100644
> --- a/net/core/net_namespace.c
> +++ b/net/core/net_namespace.c
> @@ -434,6 +434,9 @@ static __net_init int setup_net(struct net *net)
>         LIST_HEAD(net_exit_list);
>         int error = 0;
>
> +       init_llist_node(&net->defer_free_list);
> +       init_llist_node(&net->cleanup_list);
> +
>         preempt_disable();
>         net->net_cookie = gen_cookie_next(&net_cookie);
>         preempt_enable();
> --
> 2.34.1
>