linux-kernel - Re: [PATCH] tty: serial: ip22zilog: Use platform device for probing

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2025072321-scorer-surfacing-1cdf@gregkh>
Date: Wed, 23 Jul 2025 14:02:43 +0200
From: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To: Thomas Bogendoerfer <tsbogend@...ha.franken.de>
Cc: Jiri Slaby <jirislaby@...nel.org>, linux-mips@...r.kernel.org,
	linux-kernel@...r.kernel.org, linux-serial@...r.kernel.org
Subject: Re: [PATCH] tty: serial: ip22zilog: Use platform device for probing

On Wed, Jul 23, 2025 at 01:58:23PM +0200, Thomas Bogendoerfer wrote:
> +static int __init sgi_zilog_devinit(void)
> +{
> +	struct resource res;
> +
> +	memset(&res, 0, sizeof(res));
> +	res.start = HPC3_CHIP0_BASE + offsetof(struct hpc3_regs, rtcregs);
> +	res.end = res.start + sizeof(hpc3c0->rtcregs) - 1;
> +	res.flags = IORESOURCE_MEM;
> +
> +	return platform_device_register(&zilog_device);

Odd function, why do you need "res" at all if you do not do anything
with it?

thanks,

greg k-h