linux-kernel - Re: [PATCH] tty: serial: ip22zilog: Use platform device for probing

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <aIDWRZXXfvaO_4xl@alpha.franken.de>
Date: Wed, 23 Jul 2025 14:32:05 +0200
From: Thomas Bogendoerfer <tsbogend@...ha.franken.de>
To: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Cc: Jiri Slaby <jirislaby@...nel.org>, linux-mips@...r.kernel.org,
	linux-kernel@...r.kernel.org, linux-serial@...r.kernel.org
Subject: Re: [PATCH] tty: serial: ip22zilog: Use platform device for probing

On Wed, Jul 23, 2025 at 02:02:43PM +0200, Greg Kroah-Hartman wrote:
> On Wed, Jul 23, 2025 at 01:58:23PM +0200, Thomas Bogendoerfer wrote:
> > +static int __init sgi_zilog_devinit(void)
> > +{
> > +	struct resource res;
> > +
> > +	memset(&res, 0, sizeof(res));
> > +	res.start = HPC3_CHIP0_BASE + offsetof(struct hpc3_regs, rtcregs);
> > +	res.end = res.start + sizeof(hpc3c0->rtcregs) - 1;
> > +	res.flags = IORESOURCE_MEM;
> > +
> > +	return platform_device_register(&zilog_device);
> 
> Odd function, why do you need "res" at all if you do not do anything
> with it?

ouch, leftover from copy&paste... will remove in v2

Thomas.

-- 
Crap can work. Given enough thrust pigs will fly, but it's not necessarily a
good idea.                                                [ RFC1925, 2.3 ]