linux-kernel - Re: [PATCH v3] iio: adc: spear_adc: mask SPEAR_ADC_STATUS channel and avg sample before setting register

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aIDoZHBjO4tU3Gkh@smile.fi.intel.com>
Date: Wed, 23 Jul 2025 16:49:24 +0300
From: Andy Shevchenko <andriy.shevchenko@...el.com>
To: Rodrigo Gobbi <rodrigo.gobbi.7@...il.com>
Cc: jic23@...nel.org, dlechner@...libre.com, nuno.sa@...log.com,
	andy@...nel.org, ~lkcamp/patches@...ts.sr.ht,
	linux-iio@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3] iio: adc: spear_adc: mask SPEAR_ADC_STATUS channel
 and avg sample before setting register

On Thu, Jul 17, 2025 at 07:13:49PM -0300, Rodrigo Gobbi wrote:
> avg sample info is a bit field coded inside the following
> bits: 5,6,7 and 8 of a device status register.
> 
> channel num info the same, but over bits: 1, 2 and 3.
> 
> mask both values in order to avoid touching other register bits,
> since the first info (avg sample), came from dt.

Is there any issue with a Shift key?

> Signed-off-by: Rodrigo Gobbi <rodrigo.gobbi.7@...il.com>

...

>  #include <linux/clk.h>
>  #include <linux/err.h>
>  #include <linux/completion.h>
> +#include <linux/bitfield.h>

While it looks unordered, it's still better to squeeze a new header to the
place which organises a longest (but sparse) group of ordered headers. This
will reduce churn in the future for the ordering changes.

>  #include <linux/iio/iio.h>
>  #include <linux/iio/sysfs.h>

-- 
With Best Regards,
Andy Shevchenko