linux-kernel - Re: [PATCH v3] iio: adc: spear_adc: mask SPEAR_ADC_STATUS channel and avg sample before setting register

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20250724134758.43df3ccc@jic23-huawei>
Date: Thu, 24 Jul 2025 13:47:58 +0100
From: Jonathan Cameron <jic23@...nel.org>
To: Andy Shevchenko <andriy.shevchenko@...el.com>
Cc: Rodrigo Gobbi <rodrigo.gobbi.7@...il.com>, dlechner@...libre.com,
 nuno.sa@...log.com, andy@...nel.org, ~lkcamp/patches@...ts.sr.ht,
 linux-iio@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3] iio: adc: spear_adc: mask SPEAR_ADC_STATUS channel
 and avg sample before setting register

On Wed, 23 Jul 2025 16:49:24 +0300
Andy Shevchenko <andriy.shevchenko@...el.com> wrote:

> On Thu, Jul 17, 2025 at 07:13:49PM -0300, Rodrigo Gobbi wrote:
> > avg sample info is a bit field coded inside the following
> > bits: 5,6,7 and 8 of a device status register.
> > 
> > channel num info the same, but over bits: 1, 2 and 3.
> > 
> > mask both values in order to avoid touching other register bits,
> > since the first info (avg sample), came from dt.  
> 
> Is there any issue with a Shift key?
Sprinkled some capitals.
> 
> > Signed-off-by: Rodrigo Gobbi <rodrigo.gobbi.7@...il.com>  
> 
> ...
> 
> >  #include <linux/clk.h>
> >  #include <linux/err.h>
> >  #include <linux/completion.h>
> > +#include <linux/bitfield.h>  
> 
> While it looks unordered, it's still better to squeeze a new header to the
> place which organises a longest (but sparse) group of ordered headers. This
> will reduce churn in the future for the ordering changes.

The full set is currently:

#include <linux/mod_devicetable.h>
#include <linux/module.h>
#include <linux/platform_device.h>
#include <linux/property.h>
#include <linux/interrupt.h>
#include <linux/device.h>
#include <linux/kernel.h>
#include <linux/slab.h>
#include <linux/io.h>
#include <linux/clk.h>
#include <linux/err.h>
#include <linux/completion.h>
#include <linux/bitfield.h>

I'll move it to before clk, but that's only a really minor improvement!


> 
> >  #include <linux/iio/iio.h>
> >  #include <linux/iio/sysfs.h>  
>