[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <ba1cb0dd-031a-4f55-8484-1acf321c4876@kernel.org>
Date: Thu, 24 Jul 2025 09:15:08 +0200
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Donald Shannon <donalds@...dia.com>, robh@...nel.org, krzk+dt@...nel.org,
conor+dt@...nel.org
Cc: joel@....id.au, andrew@...econstruct.com.au, devicetree@...r.kernel.org,
linux-arm-kernel@...ts.infradead.org, linux-aspeed@...ts.ozlabs.org,
linux-kernel@...r.kernel.org
Subject: Re: [PATCH v6 1/2] dt-bindings: arm: aspeed: Add NVIDIA GB200-UT3.0b
board
On 23/07/2025 23:58, Donald Shannon wrote:
> On 7/22/25 22:56, Krzysztof Kozlowski wrote:
>> External email: Use caution opening links or attachments
>>
>>
>> On 23/07/2025 03:42, Donald Shannon wrote:
>>> This is an Aspeed AST2600 based unit testing platform for GB200.
>>> UT3.0b is different than nvidia-gb200nvl-bmc due to networking topology
>>> differences, additional gpio expanders, and voltage regulator gating
>>> some devices.
>>>
>>> Reference to Ast2600 SOC [1].
>>> Reference to Blackwell GB200NVL Platform [2].
>>>
>>> Link: https://www.aspeedtech.com/server_ast2600/ [1]
>>> Link: https://nvdam.widen.net/s/wwnsxrhm2w/blackwell-datasheet-3384703 [2]
>>> Signed-off-by: Donald Shannon <donalds@...dia.com>
>>> Acked-by: Krzysztof Kozlowski <krzk@...nel.org>
>> Why are you faking tags? No, you cannot just add whatever you want.
>>
>> Best regards,
>> Krzysztof
>
> Hi Krzysztof,
>
> I thinkĀ I was confused by your message on my V5 patch. I will remove the Acked-by and resubmit:
>
>> A nit, subject: drop second/last, redundant "binding". The
>> "dt-bindings" prefix is already stating that these are bindings.
>> See also:
>> https://elixir.bootlin.com/linux/v6.7-rc8/source/Documentation/devicetree/bindings/submitting-patches.rst#L18
>>
>> With above two:
>>
>> Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
And what did you paste in your patch?
And why?
Best regards,
Krzysztof
Powered by blists - more mailing lists