[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <24ce8704-1f9c-437e-ae72-1c6c3c672c2b@nvidia.com>
Date: Wed, 23 Jul 2025 14:58:14 -0700
From: Donald Shannon <donalds@...dia.com>
To: Krzysztof Kozlowski <krzk@...nel.org>, robh@...nel.org,
krzk+dt@...nel.org, conor+dt@...nel.org
Cc: joel@....id.au, andrew@...econstruct.com.au, devicetree@...r.kernel.org,
linux-arm-kernel@...ts.infradead.org, linux-aspeed@...ts.ozlabs.org,
linux-kernel@...r.kernel.org
Subject: Re: [PATCH v6 1/2] dt-bindings: arm: aspeed: Add NVIDIA GB200-UT3.0b
board
On 7/22/25 22:56, Krzysztof Kozlowski wrote:
> External email: Use caution opening links or attachments
>
>
> On 23/07/2025 03:42, Donald Shannon wrote:
>> This is an Aspeed AST2600 based unit testing platform for GB200.
>> UT3.0b is different than nvidia-gb200nvl-bmc due to networking topology
>> differences, additional gpio expanders, and voltage regulator gating
>> some devices.
>>
>> Reference to Ast2600 SOC [1].
>> Reference to Blackwell GB200NVL Platform [2].
>>
>> Link: https://www.aspeedtech.com/server_ast2600/ [1]
>> Link: https://nvdam.widen.net/s/wwnsxrhm2w/blackwell-datasheet-3384703 [2]
>> Signed-off-by: Donald Shannon <donalds@...dia.com>
>> Acked-by: Krzysztof Kozlowski <krzk@...nel.org>
> Why are you faking tags? No, you cannot just add whatever you want.
>
> Best regards,
> Krzysztof
Hi Krzysztof,
I thinkĀ I was confused by your message on my V5 patch. I will remove the Acked-by and resubmit:
>A nit, subject: drop second/last, redundant "binding". The
>"dt-bindings" prefix is already stating that these are bindings.
>See also:
>https://elixir.bootlin.com/linux/v6.7-rc8/source/Documentation/devicetree/bindings/submitting-patches.rst#L18
>
>With above two:
>
>Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
>
>
><form letter>
>This is an automated instruction, just in case, because many review
>tags are being ignored. If you know the process, just skip it entirely
>(please do not feel offended by me posting it here - no bad intentions
>intended, no patronizing, I just want to avoid wasted efforts). If you
>do not know the process, here is a short explanation:
>
>Please add Acked-by/Reviewed-by/Tested-by tags when posting new
>versions of patchset, under or above your Signed-off-by tag, unless
>patch changed significantly (e.g. new properties added to the DT
>bindings). Tag is "received", when provided in a message replied to you
>on the mailing list. Tools like b4 can help here ('b4 trailers -u ...').
>However, there's no need to repost patches *only* to add the tags. The
>upstream maintainer will do that for tags received on the version they
>apply.
Thanks,
Donald
Powered by blists - more mailing lists