linux-kernel - Re: [PATCH v5 1/2] pwm: mc33xs2410: add hwmon support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5fblcb3bbwclh4w4dm3s5ue6eplahka5idqz6z4g6ttmhqb24p@jaqznheusac5>
Date: Thu, 24 Jul 2025 09:30:16 +0200
From: Uwe Kleine-König <ukleinek@...nel.org>
To: dimitri.fedrau@...bherr.com, Guenter Roeck <linux@...ck-us.net>
Cc: Jean Delvare <jdelvare@...e.com>, Jonathan Corbet <corbet@....net>, 
	linux-pwm@...r.kernel.org, linux-kernel@...r.kernel.org, linux-hwmon@...r.kernel.org, 
	linux-doc@...r.kernel.org, Dimitri Fedrau <dima.fedrau@...il.com>
Subject: Re: [PATCH v5 1/2] pwm: mc33xs2410: add hwmon support

Hello Dimitri,

On Wed, Jul 23, 2025 at 07:34:56PM +0200, Dimitri Fedrau via B4 Relay wrote:
> @@ -361,6 +373,10 @@ static int mc33xs2410_probe(struct spi_device *spi)
>  	if (ret < 0)
>  		return dev_err_probe(dev, ret, "Failed to add pwm chip\n");
>  
> +	adev = devm_auxiliary_device_create(dev, "hwmon", NULL);
> +	if (!adev)
> +		return dev_err_probe(dev, -ENODEV, "Failed to register hwmon device\n");

Not so nice that you have to make up an error code here. But that's not
your fault but devm_auxiliary_device_create()'s which returns NULL on
error instead of an error pointer.

> +
>  	return 0;
>  }

I applied the patch for the upcoming merge window to

https://git.kernel.org/pub/scm/linux/kernel/git/ukleinek/linux.git pwm/for-next

. Expecting the merge window to open on Sunday that's a bit tight
because I like drivers to be in next for a bit before they enter the
mainline. The major code change is in drivers/hwmon and I assume Guenter
is ok with me taking it for 6.17-rc1. If not, please object, then I'll
not send it to Linus and wait for the 6.18-rc1 PR.

Best regards
Uwe

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)