linux-kernel - Re: [PATCH v5 1/2] pwm: mc33xs2410: add hwmon support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <8115ef31-52f8-40aa-9494-55acd0c691d1@roeck-us.net>
Date: Thu, 24 Jul 2025 05:59:24 -0700
From: Guenter Roeck <linux@...ck-us.net>
To: Uwe Kleine-König <ukleinek@...nel.org>,
 dimitri.fedrau@...bherr.com
Cc: Jean Delvare <jdelvare@...e.com>, Jonathan Corbet <corbet@....net>,
 linux-pwm@...r.kernel.org, linux-kernel@...r.kernel.org,
 linux-hwmon@...r.kernel.org, linux-doc@...r.kernel.org,
 Dimitri Fedrau <dima.fedrau@...il.com>
Subject: Re: [PATCH v5 1/2] pwm: mc33xs2410: add hwmon support

On 7/24/25 00:30, Uwe Kleine-König wrote:
> Hello Dimitri,
> 
> On Wed, Jul 23, 2025 at 07:34:56PM +0200, Dimitri Fedrau via B4 Relay wrote:
>> @@ -361,6 +373,10 @@ static int mc33xs2410_probe(struct spi_device *spi)
>>   	if (ret < 0)
>>   		return dev_err_probe(dev, ret, "Failed to add pwm chip\n");
>>   
>> +	adev = devm_auxiliary_device_create(dev, "hwmon", NULL);
>> +	if (!adev)
>> +		return dev_err_probe(dev, -ENODEV, "Failed to register hwmon device\n");
> 
> Not so nice that you have to make up an error code here. But that's not
> your fault but devm_auxiliary_device_create()'s which returns NULL on
> error instead of an error pointer.
> 
>> +
>>   	return 0;
>>   }
> 
> I applied the patch for the upcoming merge window to
> 
> https://git.kernel.org/pub/scm/linux/kernel/git/ukleinek/linux.git pwm/for-next
> 
> . Expecting the merge window to open on Sunday that's a bit tight
> because I like drivers to be in next for a bit before they enter the
> mainline. The major code change is in drivers/hwmon and I assume Guenter
> is ok with me taking it for 6.17-rc1. If not, please object, then I'll
> not send it to Linus and wait for the 6.18-rc1 PR.
> 

Please go ahead and apply both patches.

Thanks,
Guenter