linux-kernel - [PATCH 2/3] blk-wbt: Eliminate ambiguity in the comments of struct rq

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20250724083001.362882-3-yizhou.tang@shopee.com>
Date: Thu, 24 Jul 2025 16:30:00 +0800
From: Tang Yizhou <yizhou.tang@...pee.com>
To: axboe@...nel.dk,
	hch@....de,
	jack@...e.cz
Cc: linux-block@...r.kernel.org,
	linux-kernel@...r.kernel.org,
	tangyeechou@...il.com,
	Tang Yizhou <yizhou.tang@...pee.com>
Subject: [PATCH 2/3] blk-wbt: Eliminate ambiguity in the comments of struct rq_wb

From: Tang Yizhou <yizhou.tang@...pee.com>

In the current implementation, the last_issue and last_comp members of
struct rq_wb are used only by read requests and not by non-throttled write
requests. Therefore, eliminate the ambiguity here.

Signed-off-by: Tang Yizhou <yizhou.tang@...pee.com>
---
 block/blk-wbt.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/block/blk-wbt.c b/block/blk-wbt.c
index 30886d44f6cd..eb8037bae0bd 100644
--- a/block/blk-wbt.c
+++ b/block/blk-wbt.c
@@ -85,8 +85,8 @@ struct rq_wb {
 	u64 sync_issue;
 	void *sync_cookie;
 
-	unsigned long last_issue;		/* last non-throttled issue */
-	unsigned long last_comp;		/* last non-throttled comp */
+	unsigned long last_issue;	/* issue time of last read rq */
+	unsigned long last_comp;	/* completion time of last read rq */
 	unsigned long min_lat_nsec;
 	struct rq_qos rqos;
 	struct rq_wait rq_wait[WBT_NUM_RWQ];
-- 
2.25.1