| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <tencent_5782606120514CBCC9339FD79EBC411FB607@qq.com>
Date: Thu, 24 Jul 2025 18:37:23 +0800
From: Liya Huang <1425075683@...com>
To: Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
"Rafael J. Wysocki" <rafael@...nel.org>, Danilo Krummrich <dakr@...nel.org>
Cc: linux-kernel@...r.kernel.org, Liya Huang <1425075683@...com>
Subject: [PATCH] drivers/base/faux: Remove unnecessary match callback
The faux_match() function always returns 1, indicating a successful match.
The driver core function driver_match_device() already handles this case
by defaulting to 1 if the bus->match callback is NULL.
The implementation in driver_match_device() is:
return drv->bus->match ? drv->bus->match(dev, drv) : 1;
Therefore, the faux_match() callback is redundant and can be removed to
simplify the code, with no change in functionality.
---
drivers/base/faux: Remove unnecessary match callback
The faux_match() function always returns 1, indicating a successful match.
The driver core function driver_match_device() already handles this case
by defaulting to 1 if the bus->match callback is NULL.
The implementation in driver_match_device() is:
return drv->bus->match ? drv->bus->match(dev, drv) : 1;
Therefore, the faux_match() callback is redundant and can be removed to
simplify the code, with no change in functionality.
Signed-off-by: Liya Huang <1425075683@...com>
---
drivers/base/faux.c | 7 -------
1 file changed, 7 deletions(-)
diff --git a/drivers/base/faux.c b/drivers/base/faux.c
index f5fbda0a9a44bd8e4831ee0ef9fc87841146d2da..005e4ecac05aebccb6fcf770f7e62848d9963c88 100644
--- a/drivers/base/faux.c
+++ b/drivers/base/faux.c
@@ -33,12 +33,6 @@ static struct device faux_bus_root = {
.init_name = "faux",
};
-static int faux_match(struct device *dev, const struct device_driver *drv)
-{
- /* Match always succeeds, we only have one driver */
- return 1;
-}
-
static int faux_probe(struct device *dev)
{
struct faux_object *faux_obj = to_faux_object(dev);
@@ -77,7 +71,6 @@ static void faux_remove(struct device *dev)
static const struct bus_type faux_bus_type = {
.name = "faux",
- .match = faux_match,
.probe = faux_probe,
.remove = faux_remove,
};
---
base-commit: 89be9a83ccf1f88522317ce02f854f30d6115c41
change-id: 20250723-faux_match-f76a6456976e
Best regards,
--
Liya Huang <1425075683@...com>
Powered by blists - more mailing lists