linux-kernel - Re: [PATCH] drivers/base/faux: Remove unnecessary match callback

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2025072450-stony-spearhead-03f0@gregkh>
Date: Thu, 24 Jul 2025 13:37:08 +0200
From: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To: Liya Huang <1425075683@...com>
Cc: "Rafael J. Wysocki" <rafael@...nel.org>,
	Danilo Krummrich <dakr@...nel.org>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] drivers/base/faux: Remove unnecessary match callback

On Thu, Jul 24, 2025 at 06:37:23PM +0800, Liya Huang wrote:
> The faux_match() function always returns 1, indicating a successful match.
> The driver core function driver_match_device() already handles this case
> by defaulting to 1 if the bus->match callback is NULL.
> 
> The implementation in driver_match_device() is:
>   return drv->bus->match ? drv->bus->match(dev, drv) : 1;
> 
> Therefore, the faux_match() callback is redundant and can be removed to
> simplify the code, with no change in functionality.
> 
> ---
> drivers/base/faux: Remove unnecessary match callback
> 
> The faux_match() function always returns 1, indicating a successful match.
> The driver core function driver_match_device() already handles this case
> by defaulting to 1 if the bus->match callback is NULL.
> 
> The implementation in driver_match_device() is:
>   return drv->bus->match ? drv->bus->match(dev, drv) : 1;
> 
> Therefore, the faux_match() callback is redundant and can be removed to
> simplify the code, with no change in functionality.

Why is the changelog text here twice?  How did git send-email get this
wrong?

confused,

greg k-h