linux-kernel - Re: [PATCH v1 7/8] dt-bindings: media: Add MT8189 mediatek,vcodec-encoder

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <ca71855d3a78a213b837a3d2a48ddd82f856639f.camel@mediatek.com>
Date: Thu, 24 Jul 2025 02:55:38 +0000
From: Kyrie Wu (吴晗) <Kyrie.Wu@...iatek.com>
To: "krzk@...nel.org" <krzk@...nel.org>
CC: "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"linux-mediatek@...ts.infradead.org" <linux-mediatek@...ts.infradead.org>,
	George Sun (孙林) <George.Sun@...iatek.com>,
	Tiffany Lin (林慧珊) <tiffany.lin@...iatek.com>,
	"andrzejtp2010@...il.com" <andrzejtp2010@...il.com>,
	"linux-media@...r.kernel.org" <linux-media@...r.kernel.org>,
	"nhebert@...omium.org" <nhebert@...omium.org>, "devicetree@...r.kernel.org"
	<devicetree@...r.kernel.org>, "mchehab@...nel.org" <mchehab@...nel.org>,
	"hverkuil@...all.nl" <hverkuil@...all.nl>, "nicolas.dufresne@...labora.com"
	<nicolas.dufresne@...labora.com>, Kyrie Wu (吴晗)
	<Kyrie.Wu@...iatek.com>, Yunfei Dong (董云飞)
	<Yunfei.Dong@...iatek.com>, "conor+dt@...nel.org" <conor+dt@...nel.org>,
	Irui Wang (王瑞) <Irui.Wang@...iatek.com>,
	"robh@...nel.org" <robh@...nel.org>, "sebastian.fricke@...labora.com"
	<sebastian.fricke@...labora.com>, "linux-arm-kernel@...ts.infradead.org"
	<linux-arm-kernel@...ts.infradead.org>, "matthias.bgg@...il.com"
	<matthias.bgg@...il.com>, "christophe.jaillet@...adoo.fr"
	<christophe.jaillet@...adoo.fr>, "krzk+dt@...nel.org" <krzk+dt@...nel.org>,
	"arnd@...db.de" <arnd@...db.de>,
	Andrew-CT Chen (陳智迪)
	<Andrew-CT.Chen@...iatek.com>, AngeloGioacchino Del Regno
	<angelogioacchino.delregno@...labora.com>, "neil.armstrong@...aro.org"
	<neil.armstrong@...aro.org>
Subject: Re: [PATCH v1 7/8] dt-bindings: media: Add MT8189
 mediatek,vcodec-encoder

On Tue, 2025-07-22 at 13:09 +0200, Krzysztof Kozlowski wrote:
> External email : Please do not click links or open attachments until
> you have verified the sender or the content.
> 
> 
> On 22/07/2025 10:16, Kyrie Wu (吴晗) wrote:
> > On Tue, 2025-07-22 at 09:26 +0200, Krzysztof Kozlowski wrote:
> > > External email : Please do not click links or open attachments
> > > until
> > > you have verified the sender or the content.
> > > 
> > > 
> > > On Mon, Jul 21, 2025 at 06:55:19PM +0800, Kyrie Wu wrote:
> > > > Add MT8189 encoder compatible string, which will reference SCP
> > > > device.
> > > 
> > > And the device is not compatible or is different because of what?
> > > 
> > > Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
> > > 
> > > Best regards,
> > > Krzysztof
> > > 
> > 
> > Dear Krzysztof,
> > 
> > The reason, adding a new compatible strings for the MT8189 encoder,
> > is
> > same as for decoder, to use different of_device_id data and to
> > distinguish the chip name.
> 
> You speak about drivers, this is not relevant. Explain the hardware -
> WHY it is not compatible, what is the difference
> 
> Best regards,
> Krzysztof

Dear Krzysztof,

For encoder, the hardware differences are shown as follow:
Compared with MT8196, the maximum resolution of MT8189 encoder is only
4K, and the fps is only 30, which cannot reach the highest parameter of
MT8196: level6.2, 8K@...ps.
Compared with MT8188, the level can only support 5.1, which is less
than 5.2 of MT8188. But the maximum bitrate is 100Mbps, which is twice
that of MT8188.

The above informations will be updated to the commit messages in the
coming version.

Thanks.

Regards,
Kyire.