linux-kernel - Re: [PATCH 0/5] iio: adc: ad7137: add filter support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <itmrmxm5s4y3ytpcfuofwl4luhy6i6girzeaww5aiom6pjxhwe@dhrkgh6pcvzu>
Date: Fri, 25 Jul 2025 09:47:51 +0100
From: Nuno Sá <noname.nuno@...il.com>
To: David Lechner <dlechner@...libre.com>
Cc: Michael Hennerich <Michael.Hennerich@...log.com>, 
	Jonathan Cameron <jic23@...nel.org>, Nuno Sá <nuno.sa@...log.com>, 
	Andy Shevchenko <andy@...nel.org>, linux-iio@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 0/5] iio: adc: ad7137: add filter support

On Thu, Jul 10, 2025 at 05:47:14PM -0500, David Lechner wrote:
> On 7/10/25 5:39 PM, David Lechner wrote:
> > Adding yet another feature to the ad7173 driver, this time,
> > filter support.
> > 
> > There are a couple of leading patches to rename some stuff to minimize
> > the diff in the main patch where filter support is actually added. And
> > there is a bonus patch to clean up the ABI docs for filter_type first
> > before adding the new filter types introduced in this series.
> > 
> > This was tested on the EVAL-AD7173-8ARDZ evaluation board.
> > 
> > This series depends on a bunch of fixes, so we'll have to wait for
> > those to make it back into iio/testing before we can merge this
> > series. There is also an outstanding patch to add SPI offload support
> > to this driver, but that doesn't actually have any merge conflicts
> > with this series, so they can be applied in any order.
> > 
> > ---
> > David Lechner (5):
> >       iio: adc: ad7173: rename ad7173_chan_spec_ext_info
> >       iio: adc: ad7173: rename odr field
> >       iio: adc: ad7173: support changing filter type
> >       iio: ABI: alphabetize filter types
> >       iio: ABI: add filter types for ad7173
> > 
> I don't know why, but I really struggle to write this part number
> correctly. The subject of this cover letter is wrong, but at least
> I got it right in all of the patch subject lines.

Series looks good. Just some (apparent) typos and some other thing that
you may or may not change. So, at least with the typos fixed:

Reviewed-by: Nuno Sá <nuno.sa@...log.com>