linux-kernel - Re: [PATCH 0/5] iio: adc: ad7137: add filter support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20250727163958.1ed6e764@jic23-huawei>
Date: Sun, 27 Jul 2025 16:39:58 +0100
From: Jonathan Cameron <jic23@...nel.org>
To: David Lechner <dlechner@...libre.com>
Cc: Michael Hennerich <Michael.Hennerich@...log.com>, Nuno Sá
 <nuno.sa@...log.com>, Andy Shevchenko <andy@...nel.org>,
 linux-iio@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 0/5] iio: adc: ad7137: add filter support

On Thu, 24 Jul 2025 13:50:01 -0500
David Lechner <dlechner@...libre.com> wrote:

> On 7/24/25 8:20 AM, Jonathan Cameron wrote:
> > On Thu, 10 Jul 2025 17:47:14 -0500
> > David Lechner <dlechner@...libre.com> wrote:
> >   
> >> On 7/10/25 5:39 PM, David Lechner wrote:  
> >>> Adding yet another feature to the ad7173 driver, this time,
> >>> filter support.
> >>>
> >>> There are a couple of leading patches to rename some stuff to minimize
> >>> the diff in the main patch where filter support is actually added. And
> >>> there is a bonus patch to clean up the ABI docs for filter_type first
> >>> before adding the new filter types introduced in this series.
> >>>
> >>> This was tested on the EVAL-AD7173-8ARDZ evaluation board.
> >>>
> >>> This series depends on a bunch of fixes, so we'll have to wait for
> >>> those to make it back into iio/testing before we can merge this
> >>> series. There is also an outstanding patch to add SPI offload support
> >>> to this driver, but that doesn't actually have any merge conflicts
> >>> with this series, so they can be applied in any order.
> >>>
> >>> ---
> >>> David Lechner (5):
> >>>       iio: adc: ad7173: rename ad7173_chan_spec_ext_info
> >>>       iio: adc: ad7173: rename odr field
> >>>       iio: adc: ad7173: support changing filter type
> >>>       iio: ABI: alphabetize filter types
> >>>       iio: ABI: add filter types for ad7173
> >>>     
> >> I don't know why, but I really struggle to write this part number
> >> correctly. The subject of this cover letter is wrong, but at least
> >> I got it right in all of the patch subject lines.
> >>  
> > 
> > Series look good to me. Give me a poke if it looks like I've forgotten
> > to pick this up after the precursor fix is in my tree.
> > 
> > Jonathan  
> 
> Sure, no problem. Can we pick up PATCH 4/5 ("iio: ABI: alphabetize
> filter types") sooner though? I know there is at least one other
> series under review that is adding more filter types and I am
> getting ready to start on another one that will likely introduce
> some more variants.
> 
Sure.  Patch 4 applied to the testing branch of iio.git.

Thanks,

Jonathan