linux-kernel - Re: [PATCH 16/38] arm64: dts: mediatek: mt6331: Fix pmic, regulators, rtc, keys node names

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAC=S1nhwrq60q-=jMZQ2u8TwwG9HHnQFWrFRx58VF2K6Xi16XA@mail.gmail.com>
Date: Fri, 25 Jul 2025 18:55:59 +0800
From: Fei Shao <fshao@...omium.org>
To: AngeloGioacchino Del Regno <angelogioacchino.delregno@...labora.com>
Cc: linux-mediatek@...ts.infradead.org, robh@...nel.org, 
	daniel.lezcano@...aro.org, mwalle@...nel.org, devicetree@...r.kernel.org, 
	linus.walleij@...aro.org, linux-remoteproc@...r.kernel.org, 
	dri-devel@...ts.freedesktop.org, linux-kernel@...r.kernel.org, 
	olivia.wen@...iatek.com, shane.chien@...iatek.com, linux-gpio@...r.kernel.org, 
	linux-phy@...ts.infradead.org, airlied@...il.com, simona@...ll.ch, 
	herbert@...dor.apana.org.au, jassisinghbrar@...il.com, jiaxin.yu@...iatek.com, 
	andy.teng@...iatek.com, chunfeng.yun@...iatek.com, jieyy.yang@...iatek.com, 
	chunkuang.hu@...nel.org, conor+dt@...nel.org, jitao.shi@...iatek.com, 
	p.zabel@...gutronix.de, arnd@...db.de, kishon@...nel.org, 
	kyrie.wu@...iatek.corp-partner.google.com, maarten.lankhorst@...ux.intel.com, 
	tinghan.shen@...iatek.com, mripard@...nel.org, ck.hu@...iatek.com, 
	broonie@...nel.org, eugen.hristev@...aro.org, houlong.wei@...iatek.com, 
	matthias.bgg@...il.com, tglx@...utronix.de, mchehab@...nel.org, 
	linux-arm-kernel@...ts.infradead.org, granquet@...libre.com, 
	sam.shih@...iatek.com, mathieu.poirier@...aro.org, fparent@...libre.com, 
	andersson@...nel.org, sean.wang@...nel.org, linux-sound@...r.kernel.org, 
	lgirdwood@...il.com, vkoul@...nel.org, linux-crypto@...r.kernel.org, 
	tzimmermann@...e.de, atenart@...nel.org, krzk+dt@...nel.org, 
	linux-media@...r.kernel.org, davem@...emloft.net
Subject: Re: [PATCH 16/38] arm64: dts: mediatek: mt6331: Fix pmic, regulators,
 rtc, keys node names

On Thu, Jul 24, 2025 at 5:48 PM AngeloGioacchino Del Regno
<angelogioacchino.delregno@...labora.com> wrote:
>
> The node names for "pmic", "regulators", "rtc", and "keys" are
> dictated by the PMIC MFD binding: change those to adhere to it.
>
> Fixes: aef783f3e0ca ("arm64: dts: mediatek: Add MT6331 PMIC devicetree")
> Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@...labora.com>

Reviewed-by: Fei Shao <fshao@...omium.org>

> ---
>  arch/arm64/boot/dts/mediatek/mt6331.dtsi | 10 +++++-----
>  1 file changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/mediatek/mt6331.dtsi b/arch/arm64/boot/dts/mediatek/mt6331.dtsi
> index d89858c73ab1..243afbffa21f 100644
> --- a/arch/arm64/boot/dts/mediatek/mt6331.dtsi
> +++ b/arch/arm64/boot/dts/mediatek/mt6331.dtsi
> @@ -6,12 +6,12 @@
>  #include <dt-bindings/input/input.h>
>
>  &pwrap {
> -       pmic: mt6331 {
> +       pmic: pmic {
>                 compatible = "mediatek,mt6331";
>                 interrupt-controller;
>                 #interrupt-cells = <2>;
>
> -               mt6331regulator: mt6331regulator {
> +               mt6331regulator: regulators {
>                         compatible = "mediatek,mt6331-regulator";
>
>                         mt6331_vdvfs11_reg: buck-vdvfs11 {
> @@ -258,7 +258,7 @@ mt6331_vrtc_reg: ldo-vrtc {
>                         };
>
>                         mt6331_vdig18_reg: ldo-vdig18 {
> -                               regulator-name = "dvdd18_dig";
> +                               regulator-name = "vdig18";
>                                 regulator-min-microvolt = <1800000>;
>                                 regulator-max-microvolt = <1800000>;
>                                 regulator-ramp-delay = <0>;
> @@ -266,11 +266,11 @@ mt6331_vdig18_reg: ldo-vdig18 {
>                         };
>                 };
>
> -               mt6331rtc: mt6331rtc {
> +               mt6331rtc: rtc {
>                         compatible = "mediatek,mt6331-rtc";
>                 };
>
> -               mt6331keys: mt6331keys {
> +               mt6331keys: keys {
>                         compatible = "mediatek,mt6331-keys";
>                         power {
>                                 linux,keycodes = <KEY_POWER>;
> --
> 2.50.1
>
>