linux-kernel - Re: [PATCH 24/38] arm64: dts: mediatek: mt7986a-bpi-r3: Fix SFP I2C node names

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAC=S1nhS8yY6iWNDfv4Lwz8zUJEy0nMxC5MVZGb983hDsg7bhA@mail.gmail.com>
Date: Fri, 25 Jul 2025 18:50:41 +0800
From: Fei Shao <fshao@...omium.org>
To: AngeloGioacchino Del Regno <angelogioacchino.delregno@...labora.com>
Cc: linux-mediatek@...ts.infradead.org, robh@...nel.org, 
	daniel.lezcano@...aro.org, mwalle@...nel.org, devicetree@...r.kernel.org, 
	linus.walleij@...aro.org, linux-remoteproc@...r.kernel.org, 
	dri-devel@...ts.freedesktop.org, linux-kernel@...r.kernel.org, 
	olivia.wen@...iatek.com, shane.chien@...iatek.com, linux-gpio@...r.kernel.org, 
	linux-phy@...ts.infradead.org, airlied@...il.com, simona@...ll.ch, 
	herbert@...dor.apana.org.au, jassisinghbrar@...il.com, jiaxin.yu@...iatek.com, 
	andy.teng@...iatek.com, chunfeng.yun@...iatek.com, jieyy.yang@...iatek.com, 
	chunkuang.hu@...nel.org, conor+dt@...nel.org, jitao.shi@...iatek.com, 
	p.zabel@...gutronix.de, arnd@...db.de, kishon@...nel.org, 
	kyrie.wu@...iatek.corp-partner.google.com, maarten.lankhorst@...ux.intel.com, 
	tinghan.shen@...iatek.com, mripard@...nel.org, ck.hu@...iatek.com, 
	broonie@...nel.org, eugen.hristev@...aro.org, houlong.wei@...iatek.com, 
	matthias.bgg@...il.com, tglx@...utronix.de, mchehab@...nel.org, 
	linux-arm-kernel@...ts.infradead.org, granquet@...libre.com, 
	sam.shih@...iatek.com, mathieu.poirier@...aro.org, fparent@...libre.com, 
	andersson@...nel.org, sean.wang@...nel.org, linux-sound@...r.kernel.org, 
	lgirdwood@...il.com, vkoul@...nel.org, linux-crypto@...r.kernel.org, 
	tzimmermann@...e.de, atenart@...nel.org, krzk+dt@...nel.org, 
	linux-media@...r.kernel.org, davem@...emloft.net
Subject: Re: [PATCH 24/38] arm64: dts: mediatek: mt7986a-bpi-r3: Fix SFP I2C
 node names

On Thu, Jul 24, 2025 at 5:49 PM AngeloGioacchino Del Regno
<angelogioacchino.delregno@...labora.com> wrote:
>
> The binding wants the node to be named "i2c-number", alternatively
> "i2c@...ress", but those are named "i2c-gpio-number" instead.
>
> Rename those to i2c-0, i2c-1 to adhere to the binding and suppress
> dtbs_check warnings.
>
> Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@...labora.com>

It'd be nice to mention in v2 (if needed) that this patch also drops
redundant #address-cells and #size-cells, but it's minor.

Reviewed-by: Fei Shao <fshao@...omium.org>

> ---
>  arch/arm64/boot/dts/mediatek/mt7986a-bananapi-bpi-r3.dts | 8 ++------
>  1 file changed, 2 insertions(+), 6 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/mediatek/mt7986a-bananapi-bpi-r3.dts b/arch/arm64/boot/dts/mediatek/mt7986a-bananapi-bpi-r3.dts
> index ed79ad1ae871..6d2762866a1a 100644
> --- a/arch/arm64/boot/dts/mediatek/mt7986a-bananapi-bpi-r3.dts
> +++ b/arch/arm64/boot/dts/mediatek/mt7986a-bananapi-bpi-r3.dts
> @@ -64,23 +64,19 @@ wps-key {
>         };
>
>         /* i2c of the left SFP cage (wan) */
> -       i2c_sfp1: i2c-gpio-0 {
> +       i2c_sfp1: i2c-0 {
>                 compatible = "i2c-gpio";
>                 sda-gpios = <&pio 16 (GPIO_ACTIVE_HIGH | GPIO_OPEN_DRAIN)>;
>                 scl-gpios = <&pio 17 (GPIO_ACTIVE_HIGH | GPIO_OPEN_DRAIN)>;
>                 i2c-gpio,delay-us = <2>;
> -               #address-cells = <1>;
> -               #size-cells = <0>;
>         };
>
>         /* i2c of the right SFP cage (lan) */
> -       i2c_sfp2: i2c-gpio-1 {
> +       i2c_sfp2: i2c-1 {
>                 compatible = "i2c-gpio";
>                 sda-gpios = <&pio 18 (GPIO_ACTIVE_HIGH | GPIO_OPEN_DRAIN)>;
>                 scl-gpios = <&pio 19 (GPIO_ACTIVE_HIGH | GPIO_OPEN_DRAIN)>;
>                 i2c-gpio,delay-us = <2>;
> -               #address-cells = <1>;
> -               #size-cells = <0>;
>         };
>
>         leds {
> --
> 2.50.1
>
>