lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <CAC=S1njpbfARTSBwddCeeO+c0vvf=GVaD6+QhauJOki0NS9dTQ@mail.gmail.com>
Date: Fri, 25 Jul 2025 18:53:47 +0800
From: Fei Shao <fshao@...omium.org>
To: AngeloGioacchino Del Regno <angelogioacchino.delregno@...labora.com>
Cc: linux-mediatek@...ts.infradead.org, robh@...nel.org, 
	daniel.lezcano@...aro.org, mwalle@...nel.org, devicetree@...r.kernel.org, 
	linus.walleij@...aro.org, linux-remoteproc@...r.kernel.org, 
	dri-devel@...ts.freedesktop.org, linux-kernel@...r.kernel.org, 
	olivia.wen@...iatek.com, shane.chien@...iatek.com, linux-gpio@...r.kernel.org, 
	linux-phy@...ts.infradead.org, airlied@...il.com, simona@...ll.ch, 
	herbert@...dor.apana.org.au, jassisinghbrar@...il.com, jiaxin.yu@...iatek.com, 
	andy.teng@...iatek.com, chunfeng.yun@...iatek.com, jieyy.yang@...iatek.com, 
	chunkuang.hu@...nel.org, conor+dt@...nel.org, jitao.shi@...iatek.com, 
	p.zabel@...gutronix.de, arnd@...db.de, kishon@...nel.org, 
	kyrie.wu@...iatek.corp-partner.google.com, maarten.lankhorst@...ux.intel.com, 
	tinghan.shen@...iatek.com, mripard@...nel.org, ck.hu@...iatek.com, 
	broonie@...nel.org, eugen.hristev@...aro.org, houlong.wei@...iatek.com, 
	matthias.bgg@...il.com, tglx@...utronix.de, mchehab@...nel.org, 
	linux-arm-kernel@...ts.infradead.org, granquet@...libre.com, 
	sam.shih@...iatek.com, mathieu.poirier@...aro.org, fparent@...libre.com, 
	andersson@...nel.org, sean.wang@...nel.org, linux-sound@...r.kernel.org, 
	lgirdwood@...il.com, vkoul@...nel.org, linux-crypto@...r.kernel.org, 
	tzimmermann@...e.de, atenart@...nel.org, krzk+dt@...nel.org, 
	linux-media@...r.kernel.org, davem@...emloft.net
Subject: Re: [PATCH 18/38] arm64: dts: mediatek: mt6797: Remove bogus id
 property in i2c nodes

On Thu, Jul 24, 2025 at 5:48 PM AngeloGioacchino Del Regno
<angelogioacchino.delregno@...labora.com> wrote:
>
> All of the I2C nodes in this devicetree has a bogus "id" property,
> which was probably specifying the I2C bus number.
>
> This property was never parsed and never used - and besides, it
> also gives dtbs_check warnings: remove it from all i2c nodes.
>
> Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@...labora.com>

Reviewed-by: Fei Shao <fshao@...omium.org>

> ---
>  arch/arm64/boot/dts/mediatek/mt6797.dtsi | 10 ----------
>  1 file changed, 10 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/mediatek/mt6797.dtsi b/arch/arm64/boot/dts/mediatek/mt6797.dtsi
> index be401617dfd8..f2d93bf6a055 100644
> --- a/arch/arm64/boot/dts/mediatek/mt6797.dtsi
> +++ b/arch/arm64/boot/dts/mediatek/mt6797.dtsi
> @@ -285,7 +285,6 @@ uart3: serial@...05000 {
>         i2c0: i2c@...07000 {
>                 compatible = "mediatek,mt6797-i2c",
>                              "mediatek,mt6577-i2c";
> -               id = <0>;
>                 reg = <0 0x11007000 0 0x1000>,
>                       <0 0x11000100 0 0x80>;
>                 interrupts = <GIC_SPI 84 IRQ_TYPE_LEVEL_LOW>;
> @@ -301,7 +300,6 @@ i2c0: i2c@...07000 {
>         i2c1: i2c@...08000 {
>                 compatible = "mediatek,mt6797-i2c",
>                              "mediatek,mt6577-i2c";
> -               id = <1>;
>                 reg = <0 0x11008000 0 0x1000>,
>                       <0 0x11000180 0 0x80>;
>                 interrupts = <GIC_SPI 85 IRQ_TYPE_LEVEL_LOW>;
> @@ -317,7 +315,6 @@ i2c1: i2c@...08000 {
>         i2c8: i2c@...09000 {
>                 compatible = "mediatek,mt6797-i2c",
>                              "mediatek,mt6577-i2c";
> -               id = <8>;
>                 reg = <0 0x11009000 0 0x1000>,
>                       <0 0x11000200 0 0x80>;
>                 interrupts = <GIC_SPI 86 IRQ_TYPE_LEVEL_LOW>;
> @@ -334,7 +331,6 @@ i2c8: i2c@...09000 {
>         i2c9: i2c@...0d000 {
>                 compatible = "mediatek,mt6797-i2c",
>                              "mediatek,mt6577-i2c";
> -               id = <9>;
>                 reg = <0 0x1100d000 0 0x1000>,
>                       <0 0x11000280 0 0x80>;
>                 interrupts = <GIC_SPI 87 IRQ_TYPE_LEVEL_LOW>;
> @@ -351,7 +347,6 @@ i2c9: i2c@...0d000 {
>         i2c6: i2c@...0e000 {
>                 compatible = "mediatek,mt6797-i2c",
>                              "mediatek,mt6577-i2c";
> -               id = <6>;
>                 reg = <0 0x1100e000 0 0x1000>,
>                       <0 0x11000500 0 0x80>;
>                 interrupts = <GIC_SPI 88 IRQ_TYPE_LEVEL_LOW>;
> @@ -367,7 +362,6 @@ i2c6: i2c@...0e000 {
>         i2c7: i2c@...10000 {
>                 compatible = "mediatek,mt6797-i2c",
>                              "mediatek,mt6577-i2c";
> -               id = <7>;
>                 reg = <0 0x11010000 0 0x1000>,
>                       <0 0x11000580 0 0x80>;
>                 interrupts = <GIC_SPI 89 IRQ_TYPE_LEVEL_LOW>;
> @@ -383,7 +377,6 @@ i2c7: i2c@...10000 {
>         i2c4: i2c@...11000 {
>                 compatible = "mediatek,mt6797-i2c",
>                              "mediatek,mt6577-i2c";
> -               id = <4>;
>                 reg = <0 0x11011000 0 0x1000>,
>                       <0 0x11000300 0 0x80>;
>                 interrupts = <GIC_SPI 90 IRQ_TYPE_LEVEL_LOW>;
> @@ -399,7 +392,6 @@ i2c4: i2c@...11000 {
>         i2c2: i2c@...13000 {
>                 compatible = "mediatek,mt6797-i2c",
>                              "mediatek,mt6577-i2c";
> -               id = <2>;
>                 reg = <0 0x11013000 0 0x1000>,
>                       <0 0x11000400 0 0x80>;
>                 interrupts = <GIC_SPI 95 IRQ_TYPE_LEVEL_LOW>;
> @@ -416,7 +408,6 @@ i2c2: i2c@...13000 {
>         i2c3: i2c@...14000 {
>                 compatible = "mediatek,mt6797-i2c",
>                              "mediatek,mt6577-i2c";
> -               id = <3>;
>                 reg = <0 0x11014000 0 0x1000>,
>                       <0 0x11000480 0 0x80>;
>                 interrupts = <GIC_SPI 96 IRQ_TYPE_LEVEL_LOW>;
> @@ -433,7 +424,6 @@ i2c3: i2c@...14000 {
>         i2c5: i2c@...1c000 {
>                 compatible = "mediatek,mt6797-i2c",
>                              "mediatek,mt6577-i2c";
> -               id = <5>;
>                 reg = <0 0x1101c000 0 0x1000>,
>                       <0 0x11000380 0 0x80>;
>                 interrupts = <GIC_SPI 83 IRQ_TYPE_LEVEL_LOW>;
> --
> 2.50.1
>
>

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ