linux-kernel - Re: [PATCH 3/3] blk-wbt: doc: Update the doc of the wbt_lat

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAOB9oObOcbTU8s-rnqSeVKjCjM4Z6ySZzkkLamQ5nvVTrTH_6A@mail.gmail.com>
Date: Mon, 28 Jul 2025 00:35:05 +0800
From: Yizhou Tang <tangyeechou@...il.com>
To: Jan Kara <jack@...e.cz>
Cc: Tang Yizhou <yizhou.tang@...pee.com>, axboe@...nel.dk, hch@....de, 
	linux-block@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 3/3] blk-wbt: doc: Update the doc of the wbt_lat_usec interface

On Fri, Jul 25, 2025 at 11:49 PM Jan Kara <jack@...e.cz> wrote:
>
> On Thu 24-07-25 16:30:01, Tang Yizhou wrote:
> > From: Tang Yizhou <yizhou.tang@...pee.com>
> >
> > The symbol wb_window_usec cannot be found. Update the doc to reflect the
> > latest implementation, in other words, the cur_win_nsec member of struct
> > rq_wb.
> >
> > Signed-off-by: Tang Yizhou <yizhou.tang@...pee.com>
>
> I think the name should be actually 'curr_win_nsec' because that's the name
> of this value shown in debugfs.
>
>                                                                 Honza

Agreed, I will make the change in the next patch.

Thanks,
Yi

>
> > ---
> >  Documentation/ABI/stable/sysfs-block | 10 +++++-----
> >  1 file changed, 5 insertions(+), 5 deletions(-)
> >
> > diff --git a/Documentation/ABI/stable/sysfs-block b/Documentation/ABI/stable/sysfs-block
> > index 4ba771b56b3b..7bb4dce73eca 100644
> > --- a/Documentation/ABI/stable/sysfs-block
> > +++ b/Documentation/ABI/stable/sysfs-block
> > @@ -731,11 +731,11 @@ Contact:        linux-block@...r.kernel.org
> >  Description:
> >               [RW] If the device is registered for writeback throttling, then
> >               this file shows the target minimum read latency. If this latency
> > -             is exceeded in a given window of time (see wb_window_usec), then
> > -             the writeback throttling will start scaling back writes. Writing
> > -             a value of '0' to this file disables the feature. Writing a
> > -             value of '-1' to this file resets the value to the default
> > -             setting.
> > +             is exceeded in a given window of time (see the cur_win_nsec
> > +             member of struct rq_wb), then the writeback throttling will
> > +             start scaling back writes. Writing a value of '0' to this file
> > +             disables the feature. Writing a value of '-1' to this file
> > +             resets the value to the default setting.
> >
> >
> >  What:                /sys/block/<disk>/queue/write_cache
> > --
> > 2.25.1
> >
> --
> Jan Kara <jack@...e.com>
> SUSE Labs, CR