linux-kernel - Re: [PATCH v3] iio: light: ltr390: Add debugfs register access support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAE3SzaQSHEQ7b2AaJyEiq+vVzMLAS-KZw7Liwkn7odPDW50F8w@mail.gmail.com>
Date: Mon, 28 Jul 2025 01:53:05 +0530
From: Akshay Jindal <akshayaj.lkd@...il.com>
To: Shuah Khan <skhan@...uxfoundation.org>
Cc: anshulusr@...il.com, jic23@...nel.org, dlechner@...libre.com, 
	nuno.sa@...log.com, andy@...nel.org, shuah@...nel.org, 
	linux-iio@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3] iio: light: ltr390: Add debugfs register access support

On Fri, Jul 25, 2025 at 3:29 AM Shuah Khan <skhan@...uxfoundation.org> wrote:
>
> On 7/24/25 08:39, Akshay Jindal wrote:
> > Testing details (done for v2):
> > ==============================
> > -> Tested on Raspberrypi 4B. Follow for more details.
>
> This is way too much testing information. Summarize what you tested
> instead. It makes it easier to see the results as a summary.
>
Thanks Shuah for pointing this out. Will make sure summarized testing
information in the upcoming version/patches.

On 7/24/25 08:39, Akshay Jindal wrote:
>
> Add support for debugfs_reg_access through the driver's iio_info structure
> to enable low-level register read/write access for debugging.
>
> Signed-off-by: Akshay Jindal <akshayaj.lkd@...il.com>
> ---
>
> Changes since v2:
> ================
> - merged the regmap_range of LTR390_UP_THRESH with LTR390_LOW_THRESH.
>
> Changes since v1:
> =================
> - Replaced _[0|1|2] macros with a respective common parameterized macro.
> - Retained base macros to avoid churn.
> - Swapped regmap_write with regmap_read to avoid negate operator.
> - Simplified debugfs function by directly returning return value of
>    regmap_[read|write].
> - Replaced [readable|writeable]_reg with regmap ranges by using
>    [rd|wr]_table property of regmap_config.
> - Updated the testing details with v2 changes.

Dear Maintainers,
Is there any feedback on the v3 patch?

Thanks,
Akshay