linux-kernel - Re: [PATCH v2] mtd: spi-nor: winbond: Add support for W77Q51NW

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <0d0cd3cb-61e5-4ec6-958b-ec48b82429bf@mailbox.org>
Date: Sun, 27 Jul 2025 22:26:04 +0200
From: Marek Vasut <marek.vasut@...lbox.org>
To: Michael Walle <mwalle@...nel.org>,
 Marek Vasut <marek.vasut+renesas@...lbox.org>
Cc: linux-mtd@...ts.infradead.org, Miquel Raynal <miquel.raynal@...tlin.com>,
 Pratyush Yadav <pratyush@...nel.org>, Richard Weinberger <richard@....at>,
 Tudor Ambarus <tudor.ambarus@...aro.org>,
 Vignesh Raghavendra <vigneshr@...com>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] mtd: spi-nor: winbond: Add support for W77Q51NW

On 7/23/25 8:36 AM, Michael Walle wrote:
> On Tue Jul 22, 2025 at 4:28 PM CEST, Marek Vasut wrote:
>> On 7/22/25 10:43 AM, Michael Walle wrote:
>>> Hi Marek,
>>
>> Hi,
>>
>>>> --- a/drivers/mtd/spi-nor/winbond.c
>>>> +++ b/drivers/mtd/spi-nor/winbond.c
>>>> @@ -343,6 +343,10 @@ static const struct flash_info
>>>> winbond_nor_parts[] = {
>>>>           .id = SNOR_ID(0xef, 0x80, 0x20),
>>>>           .name = "w25q512nwm",
>>>>           .otp = SNOR_OTP(256, 3, 0x1000, 0x1000),
>>>> +    }, {
>>>> +        /* W77Q51NW */
>>>> +        .id = SNOR_ID(0xef, 0x8a, 0x1a),
>>>> +        .otp = SNOR_OTP(256, 3, 0x1000, 0x1000),
>>>
>>> Did you also test the OTP read and write? I'd guess so, because otherwise
>>> you wouldn't need that entry at all, right? Or is it because of the
>>> winbond_nor_late_init() which will be called as a manufacturer fixup?
>>> In that case we could do the same as in commit afe1ea1344bb ("mtd: spi-nor:
>>> add support for Macronix Octal flash").
>>
>> I have limited supply of these devices, so OTP is untested. The flash
>> does have OTP registers, that's why the .otp entry is there. Why should
>> I remove it if the OTP registers are in the chip ?
> 
> We only add tested features. I'm just the messenger here :o. Anyway,
> OTP is not really one-time-programmable here, you can write and
> erase it again as long as you don't lock it, if that was your
> concern.

So how do I test the OTP without locking it ?

-- 
Best regards,
Marek Vasut