linux-kernel - Re: [PATCH v2 1/3] dt-bindings: clock: qcom: Add SM8750 GPU clocks

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <a16c19e2-a4be-4c62-87f3-5d0354893bcf@kernel.org>
Date: Mon, 28 Jul 2025 07:05:55 +0200
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Konrad Dybcio <konrad.dybcio@....qualcomm.com>,
 Konrad Dybcio <konradybcio@...nel.org>
Cc: Bjorn Andersson <andersson@...nel.org>,
 Michael Turquette <mturquette@...libre.com>, Stephen Boyd
 <sboyd@...nel.org>, Rob Herring <robh@...nel.org>,
 Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley
 <conor+dt@...nel.org>, Marijn Suijten <marijn.suijten@...ainline.org>,
 linux-arm-msm@...r.kernel.org, linux-clk@...r.kernel.org,
 devicetree@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 1/3] dt-bindings: clock: qcom: Add SM8750 GPU clocks

On 25/07/2025 11:23, Konrad Dybcio wrote:
> On 7/24/25 4:42 PM, Krzysztof Kozlowski wrote:
>> On 24/07/2025 12:53, Konrad Dybcio wrote:
>>> On 7/24/25 10:18 AM, Krzysztof Kozlowski wrote:
>>>> On Wed, Jul 23, 2025 at 10:38:48PM +0200, Konrad Dybcio wrote:
>>>>> From: Konrad Dybcio <konrad.dybcio@....qualcomm.com>
>>>>>
>>>>> The SM8750 features a "traditional" GPU_CC block, much of which is
>>>>> controlled through the GMU microcontroller. Additionally, there's
>>>>> an separate GX_CC block, where the GX GDSC is moved.
>>>>>
>>>>> Add bindings to accommodate for that.
>>>>>
>>>>> Signed-off-by: Konrad Dybcio <konrad.dybcio@....qualcomm.com>
>>>>> ---
> 
> [...]
> 
>> Yes, qcom,gcc. If that was missing intentionally, it is fine assuming
>> you implement the rest of comments.
> 
> With the description addition that you suggested above, should I keep
> this file in clocks/ after all?

Good point, I don't know, this is unusual case. The question is whether
there could be user of this binding/DTS, which would need/use
clock-cells? If none of possible users could use it as a clock
controller, I think it is not a clock controller from how SW sees it.
IOW, it does not matter what it is fully (in bigger picture) if it
cannot be used in that way.

If all users of the binding can use it only as power domain provided, I
would move it to power with rest of power domains. Also rename the node
name to power-controller or power-domain.

Best regards,
Krzysztof