linux-kernel - Re: [PATCH v7 2/2] memory: mtk-smi: mt8188: Add SMI reset and clamp for MT8188

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5ee8b669b93b18eed00329be90595539bc4f3e9f.camel@mediatek.com>
Date: Mon, 28 Jul 2025 06:21:35 +0000
From: Friday Yang (杨阳) <Friday.Yang@...iatek.com>
To: "robh@...nel.org" <robh@...nel.org>, "matthias.bgg@...il.com"
	<matthias.bgg@...il.com>, Yong Wu (吴勇)
	<Yong.Wu@...iatek.com>, "p.zabel@...gutronix.de" <p.zabel@...gutronix.de>,
	"conor+dt@...nel.org" <conor+dt@...nel.org>, "krzk@...nel.org"
	<krzk@...nel.org>, AngeloGioacchino Del Regno
	<angelogioacchino.delregno@...labora.com>
CC: "linux-arm-kernel@...ts.infradead.org"
	<linux-arm-kernel@...ts.infradead.org>, "linux-kernel@...r.kernel.org"
	<linux-kernel@...r.kernel.org>, "linux-mediatek@...ts.infradead.org"
	<linux-mediatek@...ts.infradead.org>, "devicetree@...r.kernel.org"
	<devicetree@...r.kernel.org>, Project_Global_Chrome_Upstream_Group
	<Project_Global_Chrome_Upstream_Group@...iatek.com>
Subject: Re: [PATCH v7 2/2] memory: mtk-smi: mt8188: Add SMI reset and clamp
 for MT8188

On Sun, 2025-05-04 at 15:40 +0200, Krzysztof Kozlowski wrote:
> External email : Please do not click links or open attachments until
> you have verified the sender or the content.
> 
> 
> On 30/04/2025 11:45, Friday Yang wrote:
> > From: "Friday Yang" <friday.yang@...iatek.com>
> > 
> > To prevent handling glitch signals during MTCMOS on/off
> > transitions,
> > SMI requires clamp and reset operations. Parse the reset settings
> > for
> > SMI LARBs and the clamp settings for the SMI Sub-Common. Register
> > genpd callback for the SMI LARBs located in image, camera and IPE
> > subsystems, and apply reset and clamp operations within the
> > callback.
> > 
> > Signed-off-by: Friday Yang <friday.yang@...iatek.com>
> > Tested-by: Friday Yang <friday.yang@...iatek.com>
> 
> How is this possible? Are you claiming that none of other authors
> test
> their patches? How testing would be not implied by authorship?
> 

OK, I will remove this tag in the new version.

> > Reviewed-by: Yong Wu <yong.wu@...iatek.com>
> > Reviewed-by: AngeloGioacchino Del Regno <
> > angelogioacchino.delregno@...labora.com>
> > Acked-by: Rob Herring <robh@...nel.org>
> 
> Changelog says that v7 has only following changes:
> 
>   - Remove the 'devm_pm_runtime_enable' change.
> 
> While v6 had no such tags.
> 
> No clue what happened here, but looks like mess with the tags and
> really
> incomplete changelog.
> 

Apology for the miss, I will add more detailed descriptions and remove
the incorrect tags in the new version.

> Best regards,
> Krzysztof