linux-kernel - Re: [PATCH] usb: gadget: udc: renesas

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAMuHMdU0E_d3XMj6sDeJy8P_UL7ua-_6CnTYqvf2-TD-WXiR3Q@mail.gmail.com>
Date: Mon, 28 Jul 2025 10:56:18 +0200
From: Geert Uytterhoeven <geert@...ux-m68k.org>
To: Johan Hovold <johan@...nel.org>
Cc: Greg Kroah-Hartman <gregkh@...uxfoundation.org>, linux-usb@...r.kernel.org, 
	linux-kernel@...r.kernel.org, 
	Linux-Renesas <linux-renesas-soc@...r.kernel.org>
Subject: Re: [PATCH] usb: gadget: udc: renesas_usb3: drop unused module alias

Hi Johan,

Thanks for your patch, which is now commit 7b4b5591d4551efe
("usb: gadget: udc: renesas_usb3: drop unused module alias") in
usb/usb-next.

On Thu, 24 Jul 2025 at 11:21, Johan Hovold <johan@...nel.org> wrote:
> Since commit f3323cd03e58 ("usb: gadget: udc: renesas_usb3: remove R-Car
> H3 ES1.* handling") the driver only supports OF probe so drop the unused
> platform module alias.
>
> Signed-off-by: Johan Hovold <johan@...nel.org>

While I don't debate the actual change, I would like to comment on
the patch description.  The driver only ever supported OF probe.
The call to soc_device_match() was just used to override the match
data for quirk handling.

> --- a/drivers/usb/gadget/udc/renesas_usb3.c
> +++ b/drivers/usb/gadget/udc/renesas_usb3.c
> @@ -3024,4 +3024,3 @@ module_platform_driver(renesas_usb3_driver);
>  MODULE_DESCRIPTION("Renesas USB3.0 Peripheral driver");
>  MODULE_LICENSE("GPL v2");
>  MODULE_AUTHOR("Yoshihiro Shimoda <yoshihiro.shimoda.uh@...esas.com>");
> -MODULE_ALIAS("platform:renesas_usb3");

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@...ux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds