linux-kernel - Re: [PATCH] usb: gadget: udc: renesas

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aIiTCDy-_EjUt1zd@hovoldconsulting.com>
Date: Tue, 29 Jul 2025 11:23:20 +0200
From: Johan Hovold <johan@...nel.org>
To: Geert Uytterhoeven <geert@...ux-m68k.org>
Cc: Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	linux-usb@...r.kernel.org, linux-kernel@...r.kernel.org,
	Linux-Renesas <linux-renesas-soc@...r.kernel.org>
Subject: Re: [PATCH] usb: gadget: udc: renesas_usb3: drop unused module alias

Hi Geert,

On Mon, Jul 28, 2025 at 10:56:18AM +0200, Geert Uytterhoeven wrote:

> On Thu, 24 Jul 2025 at 11:21, Johan Hovold <johan@...nel.org> wrote:
> > Since commit f3323cd03e58 ("usb: gadget: udc: renesas_usb3: remove R-Car
> > H3 ES1.* handling") the driver only supports OF probe so drop the unused
> > platform module alias.
> >
> > Signed-off-by: Johan Hovold <johan@...nel.org>
> 
> While I don't debate the actual change, I would like to comment on
> the patch description.  The driver only ever supported OF probe.
> The call to soc_device_match() was just used to override the match
> data for quirk handling.

The driver initially indeed only supported OF probe, but that changed
with commit ca02a5af650c ("usb: gadget: udc: renesas_usb3: Use
of_device_get_match_data() helper") after which the driver could at
least theoretically also bind based on the platform device name.

Johan