linux-kernel - Re: [PATCH V2 1/2] mmc: sdhci-pci-gli: Add a new function to simplify the code

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAK00qKA9EP2aV+P5XeeO2T+Vrc5wXv8Yt73b65yKNKgmkt3zRw@mail.gmail.com>
Date: Mon, 28 Jul 2025 21:50:26 +0800
From: Victor Shih <victorshihgli@...il.com>
To: Adrian Hunter <adrian.hunter@...el.com>
Cc: ulf.hansson@...aro.org, linux-mmc@...r.kernel.org, 
	linux-kernel@...r.kernel.org, benchuanggli@...il.com, 
	ben.chuang@...esyslogic.com.tw, HL.Liu@...esyslogic.com.tw, 
	Victor Shih <victor.shih@...esyslogic.com.tw>, stable@...r.kernel.org
Subject: Re: [PATCH V2 1/2] mmc: sdhci-pci-gli: Add a new function to simplify
 the code

On Mon, Jul 28, 2025 at 2:55 PM Adrian Hunter <adrian.hunter@...el.com> wrote:
>
> On 25/07/2025 13:52, Victor Shih wrote:
> > From: Victor Shih <victor.shih@...esyslogic.com.tw>
> >
>
> Need to explain in the commit message, why it has a stable tag, say:
>
>         In preparation to fix replay timer timeout, add
>         sdhci_gli_mask_replay_timer_timeout() to simplify some of the code, allowing
>         it to be re-used.
>

Hi, Adrian

I will update it in the next version.

Thanks, Victor Shih

> > Add a sdhci_gli_mask_replay_timer_timeout() function
> > to simplify some of the code, allowing it to be re-used.
> >
> > Signed-off-by: Victor Shih <victor.shih@...esyslogic.com.tw>
>
> It is preferred to have a fixes tag as well.  What about
>
> Fixes: 1ae1d2d6e555e ("mmc: sdhci-pci-gli: Add Genesys Logic GL9763E support")
>

Hi, Adrian

I will add this fixes tag in the next version.

Thanks, Victor Shih

> > Cc: stable@...r.kernel.org
> > ---
> >  drivers/mmc/host/sdhci-pci-gli.c | 30 ++++++++++++++++--------------
> >  1 file changed, 16 insertions(+), 14 deletions(-)
> >
> > diff --git a/drivers/mmc/host/sdhci-pci-gli.c b/drivers/mmc/host/sdhci-pci-gli.c
> > index 4c2ae71770f7..98ee3191b02f 100644
> > --- a/drivers/mmc/host/sdhci-pci-gli.c
> > +++ b/drivers/mmc/host/sdhci-pci-gli.c
> > @@ -287,6 +287,20 @@
> >  #define GLI_MAX_TUNING_LOOP 40
> >
> >  /* Genesys Logic chipset */
> > +static void sdhci_gli_mask_replay_timer_timeout(struct pci_dev *dev)
>
> dev -> pdev
>

Hi, Adrian

Sorry, that's my mistake, it should be "(struct pci_dev *pdev)".
I will update it in the next version.

Thanks, Victor Shih

> > +{
> > +     int aer;
> > +     u32 value;
> > +
> > +     /* mask the replay timer timeout of AER */
> > +     aer = pci_find_ext_capability(pdev, PCI_EXT_CAP_ID_ERR);
> > +     if (aer) {
> > +             pci_read_config_dword(pdev, aer + PCI_ERR_COR_MASK, &value);
> > +             value |= PCI_ERR_COR_REP_TIMER;
> > +             pci_write_config_dword(pdev, aer + PCI_ERR_COR_MASK, value);
> > +     }
> > +}
> > +
> >  static inline void gl9750_wt_on(struct sdhci_host *host)
> >  {
> >       u32 wt_value;
> > @@ -607,7 +621,6 @@ static void gl9750_hw_setting(struct sdhci_host *host)
> >  {
> >       struct sdhci_pci_slot *slot = sdhci_priv(host);
> >       struct pci_dev *pdev;
> > -     int aer;
> >       u32 value;
> >
> >       pdev = slot->chip->pdev;
> > @@ -626,12 +639,7 @@ static void gl9750_hw_setting(struct sdhci_host *host)
> >       pci_set_power_state(pdev, PCI_D0);
> >
> >       /* mask the replay timer timeout of AER */
> > -     aer = pci_find_ext_capability(pdev, PCI_EXT_CAP_ID_ERR);
> > -     if (aer) {
> > -             pci_read_config_dword(pdev, aer + PCI_ERR_COR_MASK, &value);
> > -             value |= PCI_ERR_COR_REP_TIMER;
> > -             pci_write_config_dword(pdev, aer + PCI_ERR_COR_MASK, value);
> > -     }
> > +     sdhci_gli_mask_replay_timer_timeout(pdev);
> >
> >       gl9750_wt_off(host);
> >  }
> > @@ -806,7 +814,6 @@ static void sdhci_gl9755_set_clock(struct sdhci_host *host, unsigned int clock)
> >  static void gl9755_hw_setting(struct sdhci_pci_slot *slot)
> >  {
> >       struct pci_dev *pdev = slot->chip->pdev;
> > -     int aer;
> >       u32 value;
> >
> >       gl9755_wt_on(pdev);
> > @@ -841,12 +848,7 @@ static void gl9755_hw_setting(struct sdhci_pci_slot *slot)
> >       pci_set_power_state(pdev, PCI_D0);
> >
> >       /* mask the replay timer timeout of AER */
> > -     aer = pci_find_ext_capability(pdev, PCI_EXT_CAP_ID_ERR);
> > -     if (aer) {
> > -             pci_read_config_dword(pdev, aer + PCI_ERR_COR_MASK, &value);
> > -             value |= PCI_ERR_COR_REP_TIMER;
> > -             pci_write_config_dword(pdev, aer + PCI_ERR_COR_MASK, value);
> > -     }
> > +     sdhci_gli_mask_replay_timer_timeout(pdev);
> >
> >       gl9755_wt_off(pdev);
> >  }
>