linux-kernel - Re: [PATCH next] dmaengine: idxd: init: Fix uninitialized use of conf_dev in idxd_setup

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <9539bae4-dedf-4495-bd6d-5a6120362250@intel.com>
Date: Mon, 28 Jul 2025 07:56:39 -0700
From: Dave Jiang <dave.jiang@...el.com>
To: Ziming Du <duziming2@...wei.com>, dmaengine@...r.kernel.org
Cc: linux-kernel@...r.kernel.org, vkoul@...nel.org, vinicius.gomes@...el.com,
 liuyongqiang13@...wei.com
Subject: Re: [PATCH next] dmaengine: idxd: init: Fix uninitialized use of
 conf_dev in idxd_setup_wqs()



On 7/28/25 4:51 AM, Ziming Du wrote:
> Fix Smatch-detected issue:
> drivers/dma/idxd/init.c:246 idxd_setup_wqs() error:
> uninitialized symbol'conf_dev'
> 
> 'conf_dev' may be used uninitialized in error handling paths.
> Specifically, if the memory allocation for 'wq' fails, the code
> jumps to 'err', and attempt to call put_device(conf_dev), without
> ensuring that conf_dev has been properly initialized.
> 
> Fix it by initializing conf_dev to NULL at declaration.
> 
> Signed-off-by: Ziming Du <duziming2@...wei.com>

Reviewed-by: Dave Jiang <dave.jiang@...el.com>
> ---
>  drivers/dma/idxd/init.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/dma/idxd/init.c b/drivers/dma/idxd/init.c
> index 35bdefd3728b..2b61f26af1f6 100644
> --- a/drivers/dma/idxd/init.c
> +++ b/drivers/dma/idxd/init.c
> @@ -178,7 +178,7 @@ static int idxd_setup_wqs(struct idxd_device *idxd)
>  {
>  	struct device *dev = &idxd->pdev->dev;
>  	struct idxd_wq *wq;
> -	struct device *conf_dev;
> +	struct device *conf_dev = NULL;
>  	int i, rc;
>  
>  	idxd->wqs = kcalloc_node(idxd->max_wqs, sizeof(struct idxd_wq *),