linux-kernel - Re: [PATCH linux-next] signal: Remove outdated __send_signal references in do_notify

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <878qk8pdkd.ffs@tglx>
Date: Mon, 28 Jul 2025 16:58:26 +0200
From: Thomas Gleixner <tglx@...utronix.de>
To: fan.yu9@....com.cn, frederic@...nel.org, peterz@...radead.org,
 oleg@...hat.com, brauner@...nel.org, iro@...iv.linux.org.uk,
 joel.granados@...nel.org, lorenzo.stoakes@...cle.com
Cc: linux-kernel@...r.kernel.org, xu.xin16@....com.cn, yang.yang29@....com.cn
Subject: Re: [PATCH linux-next] signal: Remove outdated __send_signal
 references in  do_notify_parent

On Mon, Jul 28 2025 at 16:24, fan wrote:
> From: Fan Yu <fan.yu9@....com.cn>
>
> The function __send_signal was renamed to __send_signal_locked in

Just use __send_signal() and __send_signal_locked() which makes it
entirely clear that this is about functions, so you can spare 'The
function'. Same for the subject.

> commit 157cc18122b4 ("signal: Rename send_signal send_signal_locked"),
> making the existing comments in do_notify_parent obsolete.
>
> This patch removes these outdated references to maintain code clarity

# git grep 'This patch' Documentation/process/

> and prevent confusion about the current implementation.
>
> Signed-off-by: Fan Yu <fan.yu9@....com.cn>
> ---
>  kernel/signal.c | 5 +----
>  1 file changed, 1 insertion(+), 4 deletions(-)
>
> diff --git a/kernel/signal.c b/kernel/signal.c
> index e2c928de7d2c..30a52d884f87 100644
> --- a/kernel/signal.c
> +++ b/kernel/signal.c
> @@ -2251,10 +2251,7 @@ bool do_notify_parent(struct task_struct *tsk, int sig)
>  		if (psig->action[SIGCHLD-1].sa.sa_handler == SIG_IGN)
>  			sig = 0;
>  	}
> -	/*
> -	 * Send with __send_signal as si_pid and si_uid are in the
> -	 * parent's namespaces.
> -	 */
> +

Why are you removing the complete comment instead of just renaming the
stale reference? 

commit 61e713bdca36 ("signal: Avoid corrupting si_pid and si_uid in
do_notify_parent") put that comment there for a reason.

Thanks

        tglx