linux-kernel - Re: [PATCH v2] mtd: spi-nor: winbond: Add support for W77Q51NW

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <d592e97a-fad2-4269-b854-d3e82d985035@mailbox.org>
Date: Tue, 29 Jul 2025 05:51:55 +0200
From: Marek Vasut <marek.vasut@...lbox.org>
To: Michael Walle <mwalle@...nel.org>
Cc: linux-mtd@...ts.infradead.org, Miquel Raynal <miquel.raynal@...tlin.com>,
 Pratyush Yadav <pratyush@...nel.org>, Richard Weinberger <richard@....at>,
 Tudor Ambarus <tudor.ambarus@...aro.org>,
 Vignesh Raghavendra <vigneshr@...com>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] mtd: spi-nor: winbond: Add support for W77Q51NW

On 7/28/25 8:32 AM, Michael Walle wrote:
>>>> I have limited supply of these devices, so OTP is untested. The flash
>>>> does have OTP registers, that's why the .otp entry is there. Why should
>>>> I remove it if the OTP registers are in the chip ?
>>>
>>> We only add tested features. I'm just the messenger here :o. Anyway,
>>> OTP is not really one-time-programmable here, you can write and
>>> erase it again as long as you don't lock it, if that was your
>>> concern.
>>
>> So how do I test the OTP without locking it ?
> 
> flash_otp_{write,info,dump,erase}, just don't use flash_otp_lock.

Thanks. flash_otp_dump -u /dev/mtd0 returns zeroes, so I suspect the OTP 
is not working. The chip does work even without this entry and the 
content /sys/kernel/debug/spi-nor/spi0.0/capabilities and 
/sys/kernel/debug/spi-nor/spi0.0/params did not change, so I think the 
best way forward is to drop this patch, until I can figure out the OTP 
on this chip ?

-- 
Best regards,
Marek Vasut