linux-kernel - Re: [PATCH 1/1] Add WMI driver for Redmibook keyboard.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <b9a06c17-c18d-4ff1-b020-9eea505a6f41@foxido.dev>
Date: Tue, 29 Jul 2025 11:37:47 +0300
From: Gladyshev Ilya <foxido@...ido.dev>
To: Armin Wolf <W_Armin@....de>
Cc: Hans de Goede <hansg@...nel.org>,
 Ilpo Järvinen <ilpo.jarvinen@...ux.intel.com>,
 linux-kernel@...r.kernel.org, platform-driver-x86@...r.kernel.org,
 Nikita Krasnov <nikita.nikita.krasnov@...il.com>,
 Dmitry Torokhov <dmitry.torokhov@...il.com>,
 "open list:INPUT (KEYBOARD, MOUSE, JOYSTICK, TOUCHSCREEN)..."
 <linux-input@...r.kernel.org>
Subject: Re: [PATCH 1/1] Add WMI driver for Redmibook keyboard.

On 7/29/25 00:47, Armin Wolf wrote:
> Am 28.07.25 um 00:34 schrieb Gladyshev Ilya:
> 
>> This driver implements support for various Fn keys (like Cut) and Xiaomi
>> specific AI button.
> 
> Interesting, i was just talking with another person about implementing a 
> WMI event
> driver for the exact same WMI event device. I CCed the person involved 
> in the discussion
> so that he can test this driver on his device as well.
> All in all the driver looks promising, but there are still things that 
> need to be improved
> before we can include this driver in the mainline kernel. For details 
> see below.
Thanks for your feedback, will fix in v2. However, I have small 
question: do I still need a mutex for linearizability if I implement 
driver via sparse-keymap? I've copied mutex from xiaomi-wmi, but as I 
looked up not all WMI keyboard drivers use it (fujitsu-laptop, acer-wmi).

--
Gladyshev Ilya