linux-kernel - Re: [PATCH] kconfig/lxdialog: replace strcpy with snprintf in print

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAK7LNAQBLKpvZnSnDQwbByVvCvSWMEJYo4=pnx6_9ZTZRqFCBQ@mail.gmail.com>
Date: Tue, 29 Jul 2025 23:11:36 +0900
From: Masahiro Yamada <masahiroy@...nel.org>
To: Suchit Karunakaran <suchitkarunakaran@...il.com>
Cc: nicolas.schier@...ux.dev, linux-kbuild@...r.kernel.org, 
	skhan@...uxfoundation.org, linux-kernel-mentees@...ts.linux.dev, 
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] kconfig/lxdialog: replace strcpy with snprintf in print_autowrap

On Sun, Jul 27, 2025 at 4:43 AM Suchit Karunakaran
<suchitkarunakaran@...il.com> wrote:
>
> strcpy() does not perform bounds checking and can lead to buffer overflows
> if the source string exceeds the destination buffer size. In
> print_autowrap(), replace strcpy() with snprintf() to safely copy the
> prompt string into the fixed-size tempstr buffer.
>
> Signed-off-by: Suchit Karunakaran <suchitkarunakaran@...il.com>
> ---

Applied to linux-kbuild.
Thanks.



>  scripts/kconfig/lxdialog/util.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/scripts/kconfig/lxdialog/util.c b/scripts/kconfig/lxdialog/util.c
> index 964139c87fcb..b34000beb294 100644
> --- a/scripts/kconfig/lxdialog/util.c
> +++ b/scripts/kconfig/lxdialog/util.c
> @@ -345,8 +345,7 @@ void print_autowrap(WINDOW * win, const char *prompt, int width, int y, int x)
>         int prompt_len, room, wlen;
>         char tempstr[MAX_LEN + 1], *word, *sp, *sp2, *newline_separator = 0;
>
> -       strcpy(tempstr, prompt);
> -
> +       snprintf(tempstr, sizeof(tempstr), "%s", prompt);
>         prompt_len = strlen(tempstr);
>
>         if (prompt_len <= width - x * 2) {      /* If prompt is short */
> --
> 2.50.1
>


-- 
Best Regards
Masahiro Yamada