linux-kernel - Re: [PATCH] gpiolib: enable CONFIG_GPIOLIB

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <476d821e-1f8a-44e3-a976-def1f435440e@app.fastmail.com>
Date: Tue, 29 Jul 2025 16:11:22 +0200
From: "Arnd Bergmann" <arnd@...db.de>
To: "Geert Uytterhoeven" <geert@...ux-m68k.org>
Cc: "Arnd Bergmann" <arnd@...nel.org>,
 "Linus Walleij" <linus.walleij@...aro.org>,
 "Bartosz Golaszewski" <brgl@...ev.pl>,
 "Alexander Sverdlin" <alexander.sverdlin@...il.com>,
 "kernel test robot" <lkp@...el.com>, "Peng Fan" <peng.fan@....com>,
 "Koichiro Den" <koichiro.den@...onical.com>, "Lee Jones" <lee@...nel.org>,
 "Geert Uytterhoeven" <geert+renesas@...der.be>,
 André Draszik <andre.draszik@...aro.org>,
 "Niko Pasaloukos" <nikolaos.pasaloukos@...ize.com>,
 "Thomas Richard" <thomas.richard@...tlin.com>, "Yixun Lan" <dlan@...too.org>,
 "Lars-Peter Clausen" <lars@...afoo.de>,
 "Andy Shevchenko" <andriy.shevchenko@...ux.intel.com>,
 "open list:GPIO SUBSYSTEM" <linux-gpio@...r.kernel.org>,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH] gpiolib: enable CONFIG_GPIOLIB_LEGACY even for !GPIOLIB

On Tue, Jul 29, 2025, at 14:12, Geert Uytterhoeven wrote:
> On Tue, 29 Jul 2025 at 13:58, Arnd Bergmann <arnd@...db.de> wrote:
>> On Tue, Jul 29, 2025, at 12:47, Geert Uytterhoeven wrote:
>> Do you have an example config that shows this problem?
>> I've tried a couple of configurations on m68k now but are unable
>> to reproduce this, using 'defconfig' (without GPIOLIB) and
>> 'm5475evb_defconfig' (with GPIOLIB).
>>
>> The intention of this patch (in combination with the previous one)
>> was that the legacy interfaces would still behave exactly like
>> before, falling back to the stubs when GPIOLIB is disabled.
>
> I haven't seen any actual failures.  When discovering
> CONFIG_GPIOLIB_LEGACY=y in all m68k defconfigs, my initial worry
> was that it would increase kernel size by needlessly including
> gpiolib-legacy.o. When that didn't turn out to be true, I started
> wondering how your commit would fix anything without including
> gpiolib-legacy.o.  Looks like any users just uses the simple static
> inlines...
> Sorry for confusing you.

No worries, thanks for paying attention to incoming changes!

If you want to see what the actual plan is, have a look at

https://git.kernel.org/pub/scm/linux/kernel/git/arnd/playground.git/log/?h=config-gpio-legacy

which ends with making GPIOLIB_LEGACY actually optional.

Any driver that actually uses the legacy gpiolib interfaces
at that point is already specific to one of the few platforms
that still have legacy gpiochips (sh, sa1100, pxa, s3c64xx,
orion5x, mv78xx0, coldfire, alchemy, txx9, bcm47xx, bcm63xx,
rb532, olpc, and a few x86 atom boards), or it has an explicit
dependency on GPIOLIB_LEGACY.

The arm boards are already on their way out, but the others
could probably use some help converting to gpio descriptors.

     Arnd