linux-kernel - Re: [PATCH] zorro: fix checkpatch error by avoiding assignment in if-statement.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAMuHMdW3JxeLEnbPqc8_Qvpr7mwHhsZoaWwB8QXTMbYRYW7-Aw@mail.gmail.com>
Date: Tue, 29 Jul 2025 17:49:30 +0200
From: Geert Uytterhoeven <geert@...ux-m68k.org>
To: Jogi Dishank <jogidishank503@...il.com>
Cc: linux-m68k@...ts.linux-m68k.org, linux-kernel@...r.kernel.org, 
	darshanrathod475@...il.com, Christophe Leroy <christophe.leroy@...roup.eu>
Subject: Re: [PATCH] zorro: fix checkpatch error by avoiding assignment in if-statement.

Hi Jogi,

On Tue, 29 Jul 2025 at 14:10, Jogi Dishank <jogidishank503@...il.com> wrote:
>
> Hi,
>
> Thank you for the suggestion.
>
> Additionally, the conditional logic is inverted to reduce indentation
> and improve readability, aligning with kernel coding style.

Thanks, but this is not how you send a v2.
Please read Documentation/process/submitting-patches.rst.

> Suggested-by: Christophe Leroy <christophe.leroy@...roup.eu>

Unless I am mistaken, Christophe merely pointed out a bug in
your first submission, he did not suggest this patch.

> Signed-off-by: Dishank Jogi <jogidishank503@...il.com>

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@...ux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds