linux-kernel - Re: [PATCH V1] ufs: core: Fix interrupt handling for MCQ Mode in ufshcd

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <0fd86741-f72e-4a52-9d2c-2388c4a26115@acm.org>
Date: Tue, 29 Jul 2025 09:24:47 -0700
From: Bart Van Assche <bvanassche@....org>
To: Nitin Rawat <quic_nitirawa@...cinc.com>, alim.akhtar@...sung.com,
 avri.altman@....com, James.Bottomley@...senPartnership.com,
 huobean@...il.com, mani@...nel.org, martin.petersen@...cle.com,
 beanhuo@...ron.com, peter.wang@...iatek.com, andre.draszik@...aro.org
Cc: linux-arm-msm@...r.kernel.org, linux-scsi@...r.kernel.org,
 linux-kernel@...r.kernel.org, Palash Kambar <quic_pkambar@...cinc.com>
Subject: Re: [PATCH V1] ufs: core: Fix interrupt handling for MCQ Mode in
 ufshcd_intr

On 7/29/25 7:37 AM, Nitin Rawat wrote:
> I reviewed your patch and test it locally—it resolves the issue.

Thanks!

> The patch looks good. Since this path handles only UIC, TM, and error 
> conditions with no IO for MCQ, we still check for outstanding_reqs and 
> UTP_TRANSFER_REQ_COMPL for the error case within ufshcd_threaded_intr in 
> the patch. In my opinion, we can skip these additional checks.

We can only skip the outstanding_reqs check if MCQ is enabled. André
Draszik is working on a patch that will cause ufshcd_intr() to be called
again for legacy mode so I prefer to keep the outstanding_reqs check.

Bart.