linux-kernel - Re: [PATCH v16 01/34] x86,fs/resctrl: Consolidate monitor event descriptions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <c9866186-a68a-4051-a031-2279ca401fef@amd.com>
Date: Wed, 30 Jul 2025 15:23:01 -0500
From: "Moger, Babu" <babu.moger@....com>
To: Reinette Chatre <reinette.chatre@...el.com>, corbet@....net,
 tony.luck@...el.com, james.morse@....com, tglx@...utronix.de,
 mingo@...hat.com, bp@...en8.de, dave.hansen@...ux.intel.com
Cc: Dave.Martin@....com, x86@...nel.org, hpa@...or.com,
 akpm@...ux-foundation.org, paulmck@...nel.org, rostedt@...dmis.org,
 Neeraj.Upadhyay@....com, david@...hat.com, arnd@...db.de, fvdl@...gle.com,
 seanjc@...gle.com, jpoimboe@...nel.org, pawan.kumar.gupta@...ux.intel.com,
 xin@...or.com, manali.shukla@....com, tao1.su@...ux.intel.com,
 sohil.mehta@...el.com, kai.huang@...el.com, xiaoyao.li@...el.com,
 peterz@...radead.org, xin3.li@...el.com, kan.liang@...ux.intel.com,
 mario.limonciello@....com, thomas.lendacky@....com, perry.yuan@....com,
 gautham.shenoy@....com, chang.seok.bae@...el.com, linux-doc@...r.kernel.org,
 linux-kernel@...r.kernel.org, peternewman@...gle.com, eranian@...gle.com
Subject: Re: [PATCH v16 01/34] x86,fs/resctrl: Consolidate monitor event
 descriptions

Hi Reinette,

On 7/30/25 14:47, Reinette Chatre wrote:
> Hi Babu,
> 
> On 7/25/25 11:29 AM, Babu Moger wrote:
>> From: Tony Luck <tony.luck@...el.com>
>>
>> There are currently only three monitor events, all associated with
>> the RDT_RESOURCE_L3 resource. Growing support for additional events
>> will be easier with some restructuring to have a single point in
>> file system code where all attributes of all events are defined.
>>
>> Place all event descriptions into an array mon_event_all[]. Doing
>> this has the beneficial side effect of removing the need for
>> rdt_resource::evt_list.
>>
>> Add resctrl_event_id::QOS_FIRST_EVENT for a lower bound on range
>> checks for event ids and as the starting index to scan mon_event_all[].
>>
>> Drop the code that builds evt_list and change the two places where
>> the list is scanned to scan mon_event_all[] instead using a new
>> helper macro for_each_mon_event().
>>
>> Architecture code now informs file system code which events are
>> available with resctrl_enable_mon_event().
>>
>> Signed-off-by: Tony Luck <tony.luck@...el.com>
>> Reviewed-by: Fenghua Yu <fenghuay@...dia.com>
>> Reviewed-by: Reinette Chatre <reinette.chatre@...el.com>
> 
> Please add your "Signed-off-by" to the commit tags of the first four patches.
> When you do, ensure it follows the expected ordering
> per "Ordering of commit tags" in Documentation/process/maintainer-tip.rst.
> 

Sure. It appears I am patch handler in this case. Seems like this is a
correct order.

Signed-off-by: Tony Luck <tony.luck@...el.com>
Signed-off-by: Babu Moger <babu.moger@....com>
Reviewed-by: Fenghua Yu <fenghuay@...dia.com>
Reviewed-by: Reinette Chatre <reinette.chatre@...el.com>

-- 
Thanks
Babu Moger