linux-kernel - Re: [PATCH 2/2] dt-bindings: nvmem: add env-size property for u-boot env layout

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250730235214.GA1907865-robh@kernel.org>
Date: Wed, 30 Jul 2025 18:52:14 -0500
From: Rob Herring <robh@...nel.org>
To: Shiji Yang <yangshiji66@...look.com>
Cc: devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
	Rafał Miłecki <rafal@...ecki.pl>,
	Srinivas Kandagatla <srini@...nel.org>,
	Krzysztof Kozlowski <krzk+dt@...nel.org>,
	Conor Dooley <conor+dt@...nel.org>
Subject: Re: [PATCH 2/2] dt-bindings: nvmem: add env-size property for u-boot
 env layout

On Wed, Jul 30, 2025 at 09:17:47PM +0800, Shiji Yang wrote:
> This newly introduced property allows users to declare the size of
> the environment storage area.

Why do you need it to be less than the partition size? They commit msg 
needs to explain that.

The partition size for fixed partitions in particular are purely a DT 
construct. No reason the partition size can't always be the env size.

> Signed-off-by: Shiji Yang <yangshiji66@...look.com>
> ---
>  .../devicetree/bindings/nvmem/layouts/u-boot,env.yaml      | 7 +++++++
>  1 file changed, 7 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/nvmem/layouts/u-boot,env.yaml b/Documentation/devicetree/bindings/nvmem/layouts/u-boot,env.yaml
> index 56a8f55d4..e0b65a53e 100644
> --- a/Documentation/devicetree/bindings/nvmem/layouts/u-boot,env.yaml
> +++ b/Documentation/devicetree/bindings/nvmem/layouts/u-boot,env.yaml
> @@ -46,6 +46,12 @@ properties:
>      type: object
>      description: Command to use for automatic booting
>  
> +  env-size:
> +    $ref: /schemas/types.yaml#/definitions/uint32
> +    description:
> +      Size of the environment storage area in bytes. If this property
> +      is not defined, the default size is the partition size.
> +
>    ethaddr:
>      type: object
>      description: Ethernet interfaces base MAC address.
> @@ -85,6 +91,7 @@ examples:
>          env: partition@...00 {
>              compatible = "u-boot,env";
>              reg = <0x40000 0x10000>;
> +            env-size = <0x1000>;
>  
>              mac: ethaddr {
>                  #nvmem-cell-cells = <1>;
> -- 
> 2.50.0
>