linux-kernel - Re: [PATCH v2 9/9] dt-bindings: nvmem: mediatek: efuse: Add support for MT8196

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250730235451.GA1911689-robh@kernel.org>
Date: Wed, 30 Jul 2025 18:54:51 -0500
From: Rob Herring <robh@...nel.org>
To: Laura Nao <laura.nao@...labora.com>
Cc: srini@...nel.org, krzk+dt@...nel.org, conor+dt@...nel.org,
	rafael@...nel.org, daniel.lezcano@...aro.org, rui.zhang@...el.com,
	lukasz.luba@....com, matthias.bgg@...il.com,
	angelogioacchino.delregno@...labora.com, wenst@...omium.org,
	nfraprado@...labora.com, arnd@...db.de, colin.i.king@...il.com,
	u.kleine-koenig@...libre.com, andrew-ct.chen@...iatek.com,
	lala.lin@...iatek.com, bchihi@...libre.com, frank-w@...lic-files.de,
	devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
	linux-pm@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
	linux-mediatek@...ts.infradead.org, kernel@...labora.com
Subject: Re: [PATCH v2 9/9] dt-bindings: nvmem: mediatek: efuse: Add support
 for MT8196

On Wed, Jul 30, 2025 at 05:21:28PM +0200, Laura Nao wrote:
> The MT8196 eFuse layout is compatible with MT8186 and shares the same
> decoding scheme for the gpu-speedbin cell.
> 
> Signed-off-by: Laura Nao <laura.nao@...labora.com>
> ---
>  Documentation/devicetree/bindings/nvmem/mediatek,efuse.yaml | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/Documentation/devicetree/bindings/nvmem/mediatek,efuse.yaml b/Documentation/devicetree/bindings/nvmem/mediatek,efuse.yaml
> index 4dc0d42df3e6..455b96c1e1f4 100644
> --- a/Documentation/devicetree/bindings/nvmem/mediatek,efuse.yaml
> +++ b/Documentation/devicetree/bindings/nvmem/mediatek,efuse.yaml
> @@ -25,6 +25,7 @@ properties:
>    compatible:
>      oneOf:
>        - items:
> +          - const: mediatek,mt8196-efuse
>            - const: mediatek,mt8188-efuse
>            - const: mediatek,mt8186-efuse

You just broke mt8188 as it had 2 entries and now has 3. I think 
(based on the commit msg) you want to change 8188 entry to an enum with 
mediatek,mt8196-efuse and mediatek,mt8188-efuse.

>        - const: mediatek,mt8186-efuse
> -- 
> 2.39.5
>